Use symlinks instead of moving build directory #278
+16
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Malax
force-pushed
the
malax/use-symlinks-for-build-dir
branch
3 times, most recently
from
cc9a60a to
b2149b5
Compare
sbt relies on stable paths for its incremental compilation cache. The buildpack previously moved the entire build directory to a temporary location to provide a stable path, then moved it back at the end. This change replaces the expensive move operations with a symlink, providing the same stable path for sbt while keeping files in their original location. This eliminates the need to rewrite PATH and GEM_PATH variables to account for the directory move.
Malax
force-pushed
the
malax/use-symlinks-for-build-dir
branch
from
b2149b5 to
4b9530a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The buildpack moves the build directory to
/tmp/scala_buildpack_build_dirto provide a stable path for sbt's incremental compilation cache, which invalidates when paths change between builds.This changes the approach from moving the directory (and moving it back at the end) to creating a symlink at the stable path pointing to the original location. This eliminates the expensive move operations while maintaining the same stable path for sbt.
Changes:
mvwithln -swhen creating the temporary build directorymvback with simplermof the symlink