-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding pg:upgrade:wait command #3273
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5eb3be6
to
6976716
Compare
91d74a4
to
1de380c
Compare
justinwilaby
requested changes
Apr 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some very minor changes recommended. Overall, it looks good! Thank you!
fc0664b
to
64e3e1b
Compare
64e3e1b
to
aa01a7f
Compare
aa01a7f
to
62d06f4
Compare
62d06f4
to
c9b7883
Compare
justinwilaby
approved these changes
Apr 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work item
This PR creates the
pg:upgrade:wait
command.Please refer to this doc for more information related to pg:upgrade:wait.
Testing
Check out this branch and run
yarn && yarn build
./bin/run pg:upgrade:prepare
on a Standard-Tier leader DB and thenpg:upgrade:wait
to see it prepare./bin/run pg:upgrade:run
on a Standard-Tier leader DB with an upgrade prepared and thenpg:upgrade:wait
to see it runScreen.Recording.2025-04-08.at.10.57.36.AM.mov
./bin/run pg:upgrade:wait
after starting an upgrade on essential db./bin/run pg:upgrade:wait
with no database argumentpg:upgrade:wait
when upgrade has been scheduled (shouldn't wait)7.
heroku help pg:upgrade:wait