Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add accounts commands #3257

Merged
merged 19 commits into from
Apr 10, 2025
Merged

feat: add accounts commands #3257

merged 19 commits into from
Apr 10, 2025

Conversation

k80bowman
Copy link
Contributor

@k80bowman k80bowman commented Mar 17, 2025

Work item

This PR moves the commands from heroku/heroku-accounts to the CLI core, migrates them to TypeScript and oclif/core v2, updates and adds descriptions and error text, and adds tests.

These commands made use of functionality from heroku-cli-utils that is implemented differently in heroku-cli/command and oclif. Because of this, the migrated commands may be implemented a little differently than the originals. The overall functionality should be roughly the same and should accomplish the same tasks.

Testing

  1. Check out this branch and run yarn && yarn build
  2. Sign into a Heroku account
  3. Run ./bin/run accounts:add ACCOUNT_NAME (the account name can be whatever makes sense to you)
  4. Run ./bin/run accounts and verify that your new account is listed
  5. Sign into a different Heroku account (I used a testing account, just be sure to sign out when you are done)
  6. Run ./bin/run accounts:add ACCOUNT_NAME using a different account name
  7. Run ./bin/run accounts and verify that both accounts are now listed
  8. Run ./bin/run accounts:current and verify that the account you are currently logged into is listed
  9. Run ./bin/run accounts:set ACCOUNT_NAME using the name of the account you are not currently logged into
  10. Run ./bin/run accounts:current and verify that it lists the account you set
  11. Run ./bin/run accounts:remove ACCOUNT_NAME using the name of the account you are not currently logged into
  12. Run ./bin/run accounts and verify that only one account is now listed

@k80bowman k80bowman temporarily deployed to AcceptanceTests March 18, 2025 21:24 — with GitHub Actions Inactive
@k80bowman k80bowman temporarily deployed to AcceptanceTests March 19, 2025 13:29 — with GitHub Actions Inactive
@k80bowman k80bowman temporarily deployed to AcceptanceTests March 19, 2025 13:35 — with GitHub Actions Inactive
@k80bowman k80bowman temporarily deployed to AcceptanceTests March 19, 2025 14:10 — with GitHub Actions Inactive
@k80bowman k80bowman temporarily deployed to AcceptanceTests March 19, 2025 14:10 — with GitHub Actions Inactive
@k80bowman k80bowman marked this pull request as ready for review March 19, 2025 14:10
@k80bowman k80bowman requested a review from a team as a code owner March 19, 2025 14:10
Copy link
Contributor

@eablack eablack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Should probably rebase, but otherwise good to :shipit:

@k80bowman k80bowman temporarily deployed to AcceptanceTests April 10, 2025 12:51 — with GitHub Actions Inactive
@k80bowman k80bowman temporarily deployed to AcceptanceTests April 10, 2025 12:51 — with GitHub Actions Inactive
@k80bowman k80bowman merged commit fc5989b into main Apr 10, 2025
8 checks passed
@k80bowman k80bowman deleted the k80/accounts branch April 10, 2025 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants