-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add accounts commands #3257
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eablack
approved these changes
Apr 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Should probably rebase, but otherwise good to
Co-authored-by: Claire Riley <[email protected]> Signed-off-by: Katy Bowman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work item
This PR moves the commands from heroku/heroku-accounts to the CLI core, migrates them to TypeScript and oclif/core v2, updates and adds descriptions and error text, and adds tests.
These commands made use of functionality from heroku-cli-utils that is implemented differently in heroku-cli/command and oclif. Because of this, the migrated commands may be implemented a little differently than the originals. The overall functionality should be roughly the same and should accomplish the same tasks.
Testing
yarn && yarn build
./bin/run accounts:add ACCOUNT_NAME
(the account name can be whatever makes sense to you)./bin/run accounts
and verify that your new account is listed./bin/run accounts:add ACCOUNT_NAME
using a different account name./bin/run accounts
and verify that both accounts are now listed./bin/run accounts:current
and verify that the account you are currently logged into is listed./bin/run accounts:set ACCOUNT_NAME
using the name of the account you are not currently logged into./bin/run accounts:current
and verify that it lists the account you set./bin/run accounts:remove ACCOUNT_NAME
using the name of the account you are not currently logged into./bin/run accounts
and verify that only one account is now listed