fix(sysinfo): do not use sysinfo on x86_64 #864
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The frequency is not meant to be a frequency that the Hermit kernel can access instead of the real-time frequency value. Hermit uses this values as some sort of a nominal frequency for counting ticks (see constant_tsc) internally. Having to rely on sysinfo is a "worst-case" scenario for architectures that do not have CPUID-like functionalities (or, if they do, we do not handle them properly yet.) Fixes hermit-os#862
|
I needed the closure from getting rid of that godforsaken problem for now (although it's still not a long-term solution) - will finish this once time allows. |
|
Actually, I'm currently working on a fix for this, but this unfortunately requires a bigger refactor. I'll create a PR for this soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The frequency is not meant to be a frequency that the Hermit kernel can access instead of the real-time frequency value. Hermit uses this values as some sort of a nominal frequency for counting ticks (see constant_tsc) internally. Having to rely on sysinfo is a "worst-case" scenario for architectures that do not have CPUID-like functionalities (or, if they do, we do not handle them properly yet.)
Fixes #862