Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tempfile): allow usage of custom tempdir locations #856

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

n0toose
Copy link
Member

@n0toose n0toose commented Jan 6, 2025

This is intended to let users optionally use custom tmpfs filesystems or store unmapped files in directories that are not monitored by the temporary file cleaner.

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 67.85714% with 9 lines in your changes missing coverage. Please review.

Project coverage is 71.69%. Comparing base (da4b63e) to head (5a66a38).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/isolation/tempdir.rs 61.11% 7 Missing ⚠️
src/bin/uhyve.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #856      +/-   ##
==========================================
- Coverage   71.86%   71.69%   -0.18%     
==========================================
  Files          23       23              
  Lines        3064     3077      +13     
==========================================
+ Hits         2202     2206       +4     
- Misses        862      871       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/bin/uhyve.rs Outdated Show resolved Hide resolved
This is intended to let users optionally use custom tmpfs filesystems
or store unmapped files in directories that are not monitored by the
temporary file cleaner.
@jounathaen
Copy link
Member

LGTM! Thank you :-)

@jounathaen jounathaen added this pull request to the merge queue Jan 13, 2025
Merged via the queue into hermit-os:main with commit eed4a1d Jan 13, 2025
11 checks passed
@jounathaen jounathaen deleted the custom-tempdir branch January 13, 2025 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants