fix(hypercall): use sanitized flags for mapped files #853
+10
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #853 +/- ##
==========================================
- Coverage 71.85% 71.81% -0.05%
==========================================
Files 23 23
Lines 3063 3058 -5
==========================================
- Hits 2201 2196 -5
Misses 862 862 ☔ View full report in Codecov by Sentry. |
n0toose
force-pushed
the
fix-flag-sanitization
branch
from
1a83781 to
b7ebe2a
Compare
n0toose
force-pushed
the
fix-flag-sanitization
branch
from
b7ebe2a to
1c4f761
Compare
Given our recently added support for directories, it is possible for a kernel to erroneously create a file inside of a mapped directory using the flags O_DIRECTORY | O_CREAT. This fixes an inconsistency where the presence of both flags at the same time (which should return -EINVAL) only takes place for temporary files.
n0toose
force-pushed
the
fix-flag-sanitization
branch
from
d7bf620 to
20616f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just spotted this unfortunate error, oops.