DS-2035 extended Subscription with filter object #1748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: VladyslavHnes <[email protected]>
MateuszJaksa
approved these changes
Feb 2, 2026
Contributor
MateuszJaksa
left a comment
MateuszJaksa
left a comment
There was a problem hiding this comment.
Looks good on my side, thanks a lot for this extension.
mujammil10
reviewed
Feb 9, 2026
| } | ||
|
|
||
| @JsonIgnoreProperties(ignoreUnknown = true) | ||
| public static class SubscriptionFilter { |
Contributor
There was a problem hiding this comment.
Shouldn't we re-use the SpatialFilter here, and have a common "filter" object across all the places ?
Contributor
Author
There was a problem hiding this comment.
Ideally yes, that's what I tried to do initially. But the SpatialFilter object is part of xyz-util and if we try to import it we will get ourselves into a circular dependency situation. I tried moving it in this module too and it's a mess. So the best option is to simply have these values as separate fields
Signed-off-by: jaksa <[email protected]>
Signed-off-by: jaksa <[email protected]>
Signed-off-by: jaksa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to extend Subscription class to contain an object that has jsonPaths and spatial filter data that Config API will populate.