Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust Android build.gradle to to run project with Gradle 8 #772

Closed

Conversation

norman-kapschefsky
Copy link

To build the android project with gradle 8+, the added configs are required.

Tested in project with ...

  • gradle 8.2
  • gradle 7.6

@henninghall
Copy link
Owner

Hi, thanks for the PR. What issues do you experience and on what react native version?

@norman-kapschefsky
Copy link
Author

Hi, thanks for the PR. What issues do you experience and on what react native version?

Hi, thanks for your question. I import the android part as a submodule to my Android project. When switching from Gradle wrapper 7.x to 8.x, my Android project isn't building anymore, because the android/build.gradle isn't configured properly for it. This PR adds the required changes to make it work.

@henninghall
Copy link
Owner

@norman-kapschefsky I understand. I hesitate a bit to merge since I suspect it might be a risk i would introduce a breaking change to older react native versions. Your conditionals could very well solve them though.

I think we have to consider this submodule case an edge case unless a few other people is running into this issue as well. I might work on better automated testing for old react native versions in the future, and if better coverage could be achieved there, I might be confident enough to merge this PR.

Until then, I suggest you to use patch-package or similar to solve your issue. Sorry for the inconvenience.


Some sources to discussions about incompatibility

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants