Skip to content

Commit

Permalink
Require aiohttp from 3.8.1 to 3.8.3 and fix Typing errors (KaSroka#35)
Browse files Browse the repository at this point in the history
* Change aiohttp version to >=3.8.1,<=3.8.3
* Fix mypy typing errors
  • Loading branch information
operinko authored Jan 11, 2023
1 parent 3ac5a15 commit e62a750
Show file tree
Hide file tree
Showing 3 changed files with 34 additions and 25 deletions.
2 changes: 1 addition & 1 deletion setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ packages = find:
python_requires = >=3.7
install_requires =
azure-iot-device==2.9.0
aiohttp==3.8.1
aiohttp>=3.8.1,<=3.8.3

[versioneer]
VCS = git
Expand Down
2 changes: 1 addition & 1 deletion toshiba_ac/__init__.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
from . import _version

__version__ = _version.get_versions()["version"] # type: ignore
__version__ = _version.get_versions()["version"]
55 changes: 32 additions & 23 deletions toshiba_ac/_version.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,10 @@
import re
import subprocess
import sys
from typing import Callable, Dict
from typing import Callable, Dict, Any


def get_keywords():
def get_keywords() -> Dict:
"""Get the keywords needed to look up the version information."""
# these strings will be replaced by git during git-archive.
# setup.py/versioneer.py will grep for the variable names, so they must
Expand All @@ -33,8 +33,15 @@ def get_keywords():
class VersioneerConfig:
"""Container for Versioneer configuration parameters."""

VCS: str
style: str
tag_prefix: str
parentdir_prefix: str
versionfile_source: str
verbose: bool

def get_config():

def get_config() -> VersioneerConfig:
"""Create, populate and return the VersioneerConfig() object."""
# these strings are filled in when 'setup.py versioneer' creates
# _version.py
Expand All @@ -56,10 +63,10 @@ class NotThisMethod(Exception):
HANDLERS: Dict[str, Dict[str, Callable]] = {}


def register_vcs_handler(vcs, method): # decorator
def register_vcs_handler(vcs: str, method: str) -> Callable: # decorator
"""Create decorator to mark a method as the handler of a VCS."""

def decorate(f):
def decorate(f: Callable) -> Callable:
"""Store f in HANDLERS[vcs][method]."""
if vcs not in HANDLERS:
HANDLERS[vcs] = {}
Expand All @@ -69,7 +76,9 @@ def decorate(f):
return decorate


def run_command(commands, args, cwd=None, verbose=False, hide_stderr=False, env=None):
def run_command(
commands: Any, args: Any, cwd: Any = None, verbose: bool = False, hide_stderr: bool = False, env: Any = None
) -> Any:
"""Call the given command(s)."""
assert isinstance(commands, list)
process = None
Expand All @@ -87,7 +96,7 @@ def run_command(commands, args, cwd=None, verbose=False, hide_stderr=False, env=
break
except OSError:
e = sys.exc_info()[1]
if e.errno == errno.ENOENT:
if e.errno == errno.ENOENT: # type: ignore
continue
if verbose:
print("unable to run %s" % dispcmd)
Expand All @@ -106,7 +115,7 @@ def run_command(commands, args, cwd=None, verbose=False, hide_stderr=False, env=
return stdout, process.returncode


def versions_from_parentdir(parentdir_prefix, root, verbose):
def versions_from_parentdir(parentdir_prefix: str, root: str, verbose: bool) -> Dict:
"""Try to determine the version from the parent directory name.
Source tarballs conventionally unpack into a directory that includes both
Expand Down Expand Up @@ -134,7 +143,7 @@ def versions_from_parentdir(parentdir_prefix, root, verbose):


@register_vcs_handler("git", "get_keywords")
def git_get_keywords(versionfile_abs):
def git_get_keywords(versionfile_abs: str) -> Dict:
"""Extract version information from the given file."""
# the code embedded in _version.py can just fetch the value of these
# keywords. When used from setup.py, we don't want to import _version.py,
Expand Down Expand Up @@ -162,7 +171,7 @@ def git_get_keywords(versionfile_abs):


@register_vcs_handler("git", "keywords")
def git_versions_from_keywords(keywords, tag_prefix, verbose):
def git_versions_from_keywords(keywords: Dict, tag_prefix: str, verbose: bool) -> Dict:
"""Get version information from git keywords."""
if "refnames" not in keywords:
raise NotThisMethod("Short version file found")
Expand Down Expand Up @@ -233,7 +242,7 @@ def git_versions_from_keywords(keywords, tag_prefix, verbose):


@register_vcs_handler("git", "pieces_from_vcs")
def git_pieces_from_vcs(tag_prefix, root, verbose, runner=run_command):
def git_pieces_from_vcs(tag_prefix: str, root: str, verbose: bool, runner: Any = run_command) -> Dict:
"""Get version from 'git describe' in the root of the source tree.
This only gets called if the git-archive 'subst' keywords were *not*
Expand Down Expand Up @@ -357,14 +366,14 @@ def git_pieces_from_vcs(tag_prefix, root, verbose, runner=run_command):
return pieces


def plus_or_dot(pieces):
def plus_or_dot(pieces: Dict) -> str:
"""Return a + if we don't already have one, else return a ."""
if "+" in pieces.get("closest-tag", ""):
return "."
return "+"


def render_pep440(pieces):
def render_pep440(pieces: Dict) -> Any:
"""Build up version string, with post-release "local version identifier".
Our goal: TAG[+DISTANCE.gHEX[.dirty]] . Note that if you
Expand All @@ -388,7 +397,7 @@ def render_pep440(pieces):
return rendered


def render_pep440_branch(pieces):
def render_pep440_branch(pieces: Dict) -> Any:
"""TAG[[.dev0]+DISTANCE.gHEX[.dirty]] .
The ".dev0" means not master branch. Note that .dev0 sorts backwards
Expand Down Expand Up @@ -417,7 +426,7 @@ def render_pep440_branch(pieces):
return rendered


def pep440_split_post(ver):
def pep440_split_post(ver: str) -> Any:
"""Split pep440 version string at the post-release segment.
Returns the release segments before the post-release and the
Expand All @@ -427,7 +436,7 @@ def pep440_split_post(ver):
return vc[0], int(vc[1] or 0) if len(vc) == 2 else None


def render_pep440_pre(pieces):
def render_pep440_pre(pieces: Dict) -> Any:
"""TAG[.postN.devDISTANCE] -- No -dirty.
Exceptions:
Expand All @@ -451,7 +460,7 @@ def render_pep440_pre(pieces):
return rendered


def render_pep440_post(pieces):
def render_pep440_post(pieces: Dict) -> Any:
"""TAG[.postDISTANCE[.dev0]+gHEX] .
The ".dev0" means dirty. Note that .dev0 sorts backwards
Expand All @@ -478,7 +487,7 @@ def render_pep440_post(pieces):
return rendered


def render_pep440_post_branch(pieces):
def render_pep440_post_branch(pieces: Dict) -> Any:
"""TAG[.postDISTANCE[.dev0]+gHEX[.dirty]] .
The ".dev0" means not master branch.
Expand Down Expand Up @@ -507,7 +516,7 @@ def render_pep440_post_branch(pieces):
return rendered


def render_pep440_old(pieces):
def render_pep440_old(pieces: Dict) -> Any:
"""TAG[.postDISTANCE[.dev0]] .
The ".dev0" means dirty.
Expand All @@ -529,7 +538,7 @@ def render_pep440_old(pieces):
return rendered


def render_git_describe(pieces):
def render_git_describe(pieces: Dict) -> Any:
"""TAG[-DISTANCE-gHEX][-dirty].
Like 'git describe --tags --dirty --always'.
Expand All @@ -549,7 +558,7 @@ def render_git_describe(pieces):
return rendered


def render_git_describe_long(pieces):
def render_git_describe_long(pieces: Dict) -> Any:
"""TAG-DISTANCE-gHEX[-dirty].
Like 'git describe --tags --dirty --always -long'.
Expand All @@ -569,7 +578,7 @@ def render_git_describe_long(pieces):
return rendered


def render(pieces, style):
def render(pieces: Dict, style: str) -> Any:
"""Render the given version pieces into the requested style."""
if pieces["error"]:
return {
Expand Down Expand Up @@ -611,7 +620,7 @@ def render(pieces, style):
}


def get_versions():
def get_versions() -> Any:
"""Get version information or return default if unable to do so."""
# I am in _version.py, which lives at ROOT/VERSIONFILE_SOURCE. If we have
# __file__, we can work backwards from there to the root. Some
Expand Down

0 comments on commit e62a750

Please sign in to comment.