Use golang native iconv library instead of gnu iconv#12
Closed
justinmichaelvieira wants to merge 1 commit intohennedo:masterfrom
Closed
Use golang native iconv library instead of gnu iconv#12justinmichaelvieira wants to merge 1 commit intohennedo:masterfrom
justinmichaelvieira wants to merge 1 commit intohennedo:masterfrom
Conversation
This was referenced Mar 8, 2023
0b8773d to
83c7409
Compare
Author
|
Closed in favor of #14 (I had accidentally put my fork as the module in go.mod, PR14 fixes that). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@hennedo, when you get a chance, can you take a look at this?
Removes github.com/qiniu/iconv in favor of github.com/justinmichaelvieira/iconv.
https://github.com/justinmichaelvieira/iconv is my fork of (current) https://github.com/mushroomsir/iconv, with CP850 support added (I would wager CP850 support was what you saw missing, when you attempted the same, so I added it in and added a test case on my fork; Opened a PR there as well, but for now the fork seems to work).
mushroomsir/iconv@6b19bf0 is the relevant commit adding CP850 to go native iconv lib.
I believe you would need to change the
moduleline 1 ingo.modback tomodule github.com/hennedo/escpos; I can either do that for you on this PR if everything else looks OK and then you can pull the single commit, or you can accept the PR and make subsequent commit to revert line 1 of yourgo.mod.Fixes #11