tbc: disable compressionin databases #471
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcopeereboom
added
type: enhancement
joshuasing
reviewed
Apr 1, 2025
Comment on lines
+306
to
+307
| if version != 3 { | ||
| t.Fatalf("expected version 3, got %v", version) |
There was a problem hiding this comment.
Could we export the ldbVersion constant in database/tbcd/level and use that here?
| @@ -82,3 +163,162 @@ func (l *ldb) v2(ctx context.Context) error { | |||
| binary.BigEndian.PutUint64(v, 2) | |||
| return l.MetadataPut(ctx, versionKey, v) | |||
| } | |||
|
|
|||
| // v3 upgrade the database from v2 to v3. | |||
There was a problem hiding this comment.
nit: small typo
Suggested change
| // v3 upgrade the database from v2 to v3. | |
| // v3 upgrades the database from v2 to v3. |
…relying on the os package which sucks balls
…ssed records, this happens for some reason
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The snappy compression does not really help disk space but does use significant CPU. Disable it and roll db to v3.
Changes