fix: buffrs should not use protoc-bin-vendored #179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomkarw
force-pushed
the
bug-buffrs-should-not-use-protoc-bin-vendored
branch
from
3653d28 to
55db0d0
Compare
Instead, we should use protoc crate for working with user provided binary.
tomkarw
force-pushed
the
bug-buffrs-should-not-use-protoc-bin-vendored
branch
from
2771449 to
1ef392f
Compare
mara-schulke
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead, we should use protoc crate for working with user provided binary.
BREAKING CHANGE: we will break workflows for people who do not have
protocinstalled locallyCloses #174.