Skip to content

Add task presets, property clearing, and system suggestions - #282

Closed
felixevers wants to merge 38 commits into
user-doc-ukmfrom
main
Closed

Add task presets, property clearing, and system suggestions#282
felixevers wants to merge 38 commits into
user-doc-ukmfrom
main

Conversation

@felixevers

@felixevers felixevers commented Jun 19, 2026

Copy link
Copy Markdown
Member

Summary

This PR introduces task presets for templating task creation, property clearing functionality for bulk data management, system suggestion modals for clinical guidelines, and significant improvements to data loading, caching, and testing infrastructure.

Key Changes

Task Presets

  • Added backend support for task presets with TaskPresetType, TaskGraphNodeType, and related GraphQL resolvers
  • Implemented task preset CRUD operations (useCreateTaskPreset, useUpdateTaskPreset, useDeleteTaskPreset, useTaskPresets)
  • Created task preset management UI at /settings/task-presets with preset editing and deletion
  • Added ApplyTaskGraph mutation to apply preset templates to patients
  • Implemented LoadTaskPresetDialog and TaskPresetDataEditor components for preset selection and configuration

Property Clearing

  • Added ClearPatientProperty and ClearTaskProperty mutations for bulk clearing of property values
  • Implemented ClearPropertyColumnDialog component with confirmation and type-in validation
  • Created hooks usePatientPropertyClearDialog and useTaskPropertyClearDialog for dialog state management
  • Added property column header menu with clear action

System Suggestions

  • Created SystemSuggestionModal component for displaying clinical guideline adherence suggestions
  • Added SystemSuggestionTasksContext for managing suggested tasks
  • Implemented LoadTaskPresetDialog integration with system suggestions
  • Added mock data support for testing suggestions

Data Loading & Caching

  • Refactored useAccumulatedPagination hook with improved pagination bounds computation and contiguous page tracking
  • Added samePaginatedListItems utility for comparing paginated list items
  • Implemented optimistic property updates with buildOptimisticProperties and applyOptimisticProperties
  • Enhanced Apollo cache policies for task presets and property mutations
  • Added mutation queue persistence for offline support

Testing Infrastructure

  • Added comprehensive E2E test support with mockBackend for deterministic GraphQL mocking
  • Created E2E tests for data loading (data-loading.spec.ts) and patient table (patient-table.spec.ts)
  • Added unit tests for pagination, view definitions, property utilities, and date utilities
  • Implemented vitest.config.ts for frontend unit testing

UI/UX Improvements

  • Added in-table edit popups for various field types (text, number, date/time, checkbox, single/multi-select)
  • Implemented EditablePropertyCell component for inline property editing
  • Added InfiniteScrollSentinel for lazy-loading lists
  • Created RowRefreshingGate context for row-level loading states
  • Added DueDateDisplay component with improved date formatting
  • Implemented list layout preference persistence (table vs. card view)

Backend Enhancements

  • Added task graph validation and application logic in task_graph.py
  • Implemented task preset resolvers with scope-based access control
  • Added database migrations for task presets and patient updated_at timestamp
  • Enhanced patient and task models with preset tracking
  • Added datetime normalization service for timezone handling

Localization

  • Added new translation keys for property clearing, time estimates, and discard confirmations
  • Updated all locale files (en-US, de-DE, es-ES, fr-FR, nl-NL, pt-BR)

Infrastructure

  • Consolidated GitHub Actions workflows into unified tests.yml with concurrency control
  • Updated Dockerfiles with pinned Alpine digest for reproducibility
  • Added .dockerignore files for cleaner builds
  • Updated dependencies (FastAPI 0.137.2, python-dotenv 1.2.2)
  • Modified Next.js dev script to use webpack explicitly

Documentation

  • Added AGENTS.md operational guide for AI contributors
  • Updated TESTING.md with consolidated workflow instructions

Notable Implementation Details

  • Task presets use a graph-based structure allowing complex task hierarchies and dependencies
  • Property clearing includes type-in confirmation to prevent accidental data loss
  • Pagination improvements support both contiguous and sparse page loading patterns
  • E2E tests use deterministic mocking to avoid external dependencies while testing real React/Apollo behavior
  • Optimistic updates maintain cache consistency during offline mutations

https://claude.ai/code/session_013kyTRPDs9AaH5newZrsw7X

felixevers and others added 30 commits March 22, 2026 13:12
@felixevers
add suggestion ui
a14534b
@felixevers
add presets
7b42574
@felixevers
Merge remote-tracking branch 'origin' into feat/task-suggestion
5804e06
@felixevers
Merge pull request #163 from helpwave/feat/task-suggestion
7646ee9 
add suggestion ui
@felixevers
use suggestion popup
19eb093
@felixevers
Merge pull request #192 from helpwave/feat/task-suggestion
46197cc 
use suggestion popup
@felixevers
fix quick-access menu item
c03828f
@felixevers
add discard confirm dialog for drawer
d2e7531
@felixevers
fix button overflow on patient data editor
76549fd
@felixevers
Merge pull request #193 from helpwave/patch/discard-confirm-dialog-on…
d353739 
…-drawer-close

Discard confirm dialog for drawer
@felixevers
fix discard dialog
62e51a5
@felixevers
upgrade python-based Dockerfiles
e7d549d
@felixevers
pin all alpine versions
ea15eb8
@felixevers
Merge pull request #208 from helpwave/patch/versions-docker-images
ec17551 
Pin all alpine versions
@aegis301 @felixevers
agents.md file (#203)
4abf1f6 
---------

Co-authored-by: Felix Evers <git@felixevers.de>
@aegis301 @felixevers
fix patient clinic source (#207)
7e26348 
* fix patient clinic source

---------

Co-authored-by: Felix Evers <git@felixevers.de>
@aegis301 @felixevers
fix last name sorting (#205)
969b87f 
---------

Co-authored-by: Felix Evers <git@felixevers.de>
@DasProffi
feat: add in table text edit pop up
5d8b005
@DasProffi
feat: add due date table update
19251f3
@DasProffi
feat: allow assignee selction in the table
7316a46
@aegis301 @DasProffi
clear property feature (#212)
43b1421 
* clear property feature

* feat: move mutations into backend

---------

Co-authored-by: Felix Thape <felix.thape@gmail.com>
@DasProffi
feat: add in table edit for properties
9b48ca0
@DasProffi
Merge remote-tracking branch 'origin/main' into issue/222-Direct-Edit…
a641a21 
…ing-on-Tasktable
@DasProffi
fix: fix build
d644982
@aegis301
Merge pull request #224 from helpwave/issue/222-Direct-Editing-on-Tas…
202abee 
…ktable

Issue/222 direct editing on tasktable
@felixevers
improve data layer and fetching behavior and fix printing
10ab3a1
@felixevers
improve cards on desktop and tablet devices
daf3d47
@felixevers
improve state handling and ui/ux features
d77c2d9
@felixevers
upgrade to @helpwave/hightide v0.10.0 (#266)
fc89679
@felixevers
improve survey participation process (#267)
f3db334
felixevers and others added 8 commits June 15, 2026 19:55
@felixevers
adopt to new date api (#269)
450fb37
@felixevers
update github actions workflow architecture
8c1c296
@felixevers
add tests for lists
163a2bc
@felixevers
update hightide to 0.10.2
f00a01c
@felixevers @claude
fix: stop inline assignee edit from marking task done locally (#279)
5debf4f 
The inline AssigneeSelect cell in the task list reused the
`optimisticUpdates` map to flag rows on change. That map stores the
task's `done` state, so editing the assignee inline optimistically
checked the task in the UI even though the backend never changed it.

Remove the erroneous optimistic `done` updates from the assignee cell's
onValueChanged/onDialogClose handlers so changing the assignee no longer
visually completes the task.

Fixes #276


Claude-Session: https://claude.ai/code/session_01Y7Bjksr92VvB6dWQoJGZN9

Co-authored-by: Claude <noreply@anthropic.com>
@felixevers @claude
Truncate text properties to 32 characters in table views (#278)
9c8790d 
* Truncate text properties to 32 characters in table views

Text (textarea) property values are now cut at 32 characters with a
trailing "..." in table cells, while the full value remains available
via the cell tooltip.

Closes #277

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01P1DT2nb74TG1FBfLamaMF1

* Truncate text property tooltip to 32 characters as well

The cell tooltip now shows the same 32-character truncated value with a
trailing "..." instead of the full text.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01P1DT2nb74TG1FBfLamaMF1

---------

Co-authored-by: Claude <noreply@anthropic.com>
@felixevers
fix property caching
2b94fdb
@felixevers @claude
fix(backend): resolve Dependabot security alerts in Python deps (#280)
4097395 
Upgrade vulnerable backend dependencies to patched versions:

- python-dotenv 1.2.1 -> 1.2.2 (CVE-2026-28684)
- strawberry-graphql 0.287.3 -> 0.315.7 (CVE-2026-47706, CVE-2026-47707)
- pytest 8.3.4 -> 9.0.3 (CVE-2025-71176)
- fastapi 0.124.4 -> 0.137.2 to allow starlette >= 1.3.1
  (CVE-2026-48817/48818, CVE-2026-54282/54283); fastapi 0.124 capped
  starlette at < 0.51.0, pinning the vulnerable 0.50.0

Bump the pytest plugins required for pytest 9 compatibility
(pytest-asyncio 0.24.0 -> 1.4.0, pytest-cov 5.0.0 -> 7.1.0).

strawberry 0.315 enforces explicit type annotations on resolver
arguments, so annotate the previously untyped `info` parameters in
UserType (organizations, tasks, root_locations).

pip-audit reports no known vulnerabilities after the upgrade and the
full backend test suite (74 tests) passes.


Claude-Session: https://claude.ai/code/session_014Utr2YbmNw9NAyHHHnYpBa

Co-authored-by: Claude <noreply@anthropic.com>
@felixevers felixevers closed this Jun 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@felixevers @aegis301 @DasProffi