Fix thread entity brain split after container restart#17
Merged
Conversation
After a container restart, the agent panel restores its thread from persistent state (creating Entity #1), then load_thread_from_agent() creates a NEW entity (Entity #2) for the same thread when a WebSocket message arrives. The panel's notify_thread_display() compared session IDs (identical for both entities) and returned early, never rebinding to the live entity. Result: Helix saw live updates but the Zed display was frozen on stale content. Fix: compare Entity references instead of session IDs so the panel detects the entity changed and rebinds via from_existing_thread(). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
notify_thread_display()compared session IDs (strings) instead of Entity references — two different GPUI entities with the same session ID were treated as identicalload_thread_from_agent()creates Entity Feature/external thread sync #2 for the same thread. Panel said "already showing, skipping" and never rebound to the live entityTest plan
build-zed release→build-ubuntu→ start new session🤖 Generated with Claude Code