Support PR Agents properly. On Helix, when does the PR ag...#2254
Open
chocobar wants to merge 3 commits into
Open
Support PR Agents properly. On Helix, when does the PR ag...#2254chocobar wants to merge 3 commits into
chocobar wants to merge 3 commits into
Conversation
- Add api/pkg/types/github.go with GitHubRepositoryContext struct and Set/GetGitHubRepositoryContext helpers (mirrors azure_devops.go pattern) - Add processGitHubPullRequest() handler to HelixCodeReviewTrigger: fetches PR details via GitHub API, sets context, calls runReviewSession() - Add getGitHubClient() to the trigger (GitHub App > OAuth > PAT > password) - Add ExternalRepositoryTypeGitHub case to ProcessGitPushEvent() switch GitHub-backed projects with PullRequestReviewsEnabled and PullRequestReviewerHelixAppID configured will now trigger the PR agent on git push, just like Azure DevOps repositories. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Spec-Ref: helix-specs@af60281e9:001635_support-pr-agents
Add GitHub-specific PR review skills (PullRequestDiff and CreateReviewComment) so the PR review agent can read diffs and post inline review comments on GitHub pull requests, matching the existing Azure DevOps PR review capability. - Add ToolTypeGitHub and AssistantGitHub types - Create GitHubPullRequestDiffTool (reads PR files/patches) - Create GitHubCreateReviewCommentTool (inline + general comments) - Register GitHub skills in inference_agent.go - Add GitHubSkill.tsx config UI component - Wire up Skills.tsx, types, flatten/unflatten logic - Regenerate OpenAPI client with new types Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Spec-Ref: helix-specs@3e65f03c3
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Spec-Ref: helix-specs@f2e18ed31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support PR Agents properly. On Helix, when does the PR agent even come into the picture? I created a project, set up a PR agent, set up a task, created a PR and merged. and I saw no interaction with the PR agent.
It appears that the PR agent only works with Azure DevOps repositories right now. GitHub and GitLab are not supported yet — they return an "unsupported external repository type" error.
The full trigger chain is:
I'm using a github repo.
Can you look into adding GitHub PR review support?
🔗 Open in Helix
🚀 Built with Helix