Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add formatter elm-format for Elm #3678

Closed
wants to merge 1 commit into from

Conversation

heyakyra
Copy link
Contributor

@heyakyra heyakyra commented Sep 4, 2022

No description provided.

@the-mikedavis
Copy link
Member

I'm not sure we should add an external formatter for Elm: elm-format would be used instead of the LSP auto-formatting (which also uses elm-format but computes the diffs) when installed. There isn't currently a way to prefer the LSP formatting but fall back to the external formatter.

@kirawi
Copy link
Member

kirawi commented Sep 4, 2022

Helix will generate a diff when using an external formatter, but it may not be as efficient on larger files because it will fallback to a less efficient fast path after a 1 second timeout.

@heyakyra
Copy link
Contributor Author

heyakyra commented Sep 4, 2022

Ah, thank you. I must be hitting this elm-tooling/elm-language-server#692

@heyakyra heyakyra closed this Sep 4, 2022
@michaeljones
Copy link
Contributor

@heyakyra - is it working smoothly for you at the moment? I seem to be in a state where the language server works for a few minutes and then just times out on every request. I can't explain it. Probably doing some silly. I'd be interested to hear confirmation that it is working for someone else though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants