Skip to content

Conversation

@m4rch3n1ng
Copy link
Contributor

@m4rch3n1ng m4rch3n1ng commented Oct 29, 2025

noticed in #14660.

in the future it might be smart to do something similar to #12759 for this, so that the injected javascript / css does not have those tokens as auto-closing, but i'll figure out how to do that relatively soon-ish, as it wasn't as easy as i hoped it would be ...

Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, as you say we may need injection-awareness for auto-pairs. </> completions are probably really helpful for HTML but they will be false-positives within script or style blocks

@the-mikedavis the-mikedavis merged commit 088eb17 into helix-editor:master Nov 3, 2025
7 checks passed
@m4rch3n1ng m4rch3n1ng deleted the html-auto-pairs branch November 3, 2025 15:23
@Rudxain
Copy link
Contributor

Rudxain commented Nov 5, 2025

I like this, but it interacts somewhat poorly with superhtml:
If I type <p (with :set auto-pairs false) then choose the completion, it replaces it by <p></p>, but with this patch I only get <p>. On the plus side, appending < (which becomes <> because of auto-pairs) makes superhtml suggest /p as the 1st option

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants