Fixes some specific rules combination#891
Merged
Merged
Conversation
In bc_assign_slots loop1, SETVAL's 'a' field is a variable index (e.g. 3), not a virtual slot number. When SETVAL appeared as an outer node in the middle of a range, its inner scan propagated that variable index to other nodes (NE's c/a fields) that coincidentally held the same value. This corrupted the virtual slot normalization so that NE and a GETVAL both ended up mapped to the same heap slot, leaving NE's 'b' operand unmapped (positive). Skip the inner scan for SETVAL so its variable index is never used as a virtual slot reference. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #885 reported some issue's with specific combination of rules. This PR fixes it