Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added -y option to skip prompt in release #5

Merged
merged 2 commits into from
Oct 22, 2015
Merged

added -y option to skip prompt in release #5

merged 2 commits into from
Oct 22, 2015

Conversation

Hypercubed
Copy link
Collaborator

Added -y prompt tio release cli options
Added option to skip prompts in release command
Added example to readme
Fixes [#1]


```json
"scripts": {
"version": "version": "chg release -y && git add -A CHANGELOG.md"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got a double "version" here

@heff
Copy link
Owner

heff commented Oct 21, 2015

One small fix. And not sure why node 0.8 is failing in Travis but I feel like we don't care about 0.8 anymore?

Otherwise lgtm!

@heff
Copy link
Owner

heff commented Oct 21, 2015

@Hypercubed added you as a collaborator, so you have push access and can accept PRs, but still make any non-doc changes through a PR that gets reviewed by one other person (a la this governance model)

@Hypercubed
Copy link
Collaborator Author

Fixed, and added a note about the required npm version.

Thanks for adding me as a collaborator. I like what you have done here, it fits well with how I use https://github.com/Hypercubed/todo-md (old code, could use a rewrite).

@Hypercubed
Copy link
Collaborator Author

The travis-ci test are failing at npm update -g npm in the node 0.8 env. It has something to do with incompatibility with npm v3. We can either fix the npm version (see https://github.com/Hypercubed/chg/blob/fix/travis/.travis.yml#L2) or remove node 0.8.

@heff
Copy link
Owner

heff commented Oct 22, 2015

Nice, todo-md looks handy. I removed 0.8 and the before_install, so it should be ok now after a merge. Gonna go ahead and pull this in.

heff added a commit that referenced this pull request Oct 22, 2015
added -y option to skip prompt in release
@heff heff merged commit 840aca4 into heff:master Oct 22, 2015
@Hypercubed Hypercubed deleted the patch branch August 22, 2016 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants