Migrate MarkdownSyntax to swift-cmark #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hebertialmeida
commented
Oct 30, 2025
| <SkippedTests> | ||
| <Test | ||
| Identifier = "ContentBlockPositionTests/testHTMLCommentPosition()"> | ||
| Identifier = "ParserInlineTests/testInvalidLink()"> |
Owner
Author
There was a problem hiding this comment.
If swiftlang/swift-cmark#84 gets merged, add this test back into the suite.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8 +/- ##
===========================================
+ Coverage 92.85% 100.00% +7.14%
===========================================
Files 1 1
Lines 182 137 -45
===========================================
- Hits 169 137 -32
+ Misses 13 0 -13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I decided to migrate to https://github.com/swiftlang/swift-cmark which is a well maintained fork of cmark-gfm + cmark + has the SPM support.
Maintaining my own fork of cmark + gfm is a lot of work, because the two repos have diverted and merging things are a pain...