Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements #492

Merged
merged 3 commits into from
Dec 17, 2024
Merged

Enhancements #492

merged 3 commits into from
Dec 17, 2024

Conversation

carlhiggs
Copy link
Collaborator

@carlhiggs carlhiggs commented Dec 17, 2024

Addresses:

  • When listing natural disasters in policy report context, these should be in lower case. I updated the English representation of phrases to have these in lower case, to address issue reported by Vincent Learnihan and @MelanieLowe. Potentially could force these to be lower case in all languages, but it may be that would not be desirable (e.g. German capitalises nouns). So for now, we've just updated this for English.
  • As per "Other (please specify)" in the policy checklist for natural disasters is not handled correctly #491, when a user specifies an 'Other' environmental disaster, this causes the policy report to fail to process; this response wasn't accounted for correctly when parsing the results for different languages. This now plugs in the 'Other' text, however it should be noted that this won't be translated. There could be work arounds (e.g. updating the phrase to the other language when generating a new report), but most elegant may be to add an override for this in the config file. This is something for us to explore. However, for now, the issue is resolved in terms of functionality even if it could be refined in terms of language. This was reported by @eugenrb and previously also by @ruoyuch (in e-mail exchange October 2024; apologies Ruoyu for not addressing this in code at the time). You can now enter other disasters with this fix, once merged.

@carlhiggs carlhiggs merged commit 3962c4e into main Dec 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant