Skip to content

Fix get_data_shape for list of Data #1270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 7, 2025
Merged

Fix get_data_shape for list of Data #1270

merged 4 commits into from
May 7, 2025

Conversation

rly
Copy link
Contributor

@rly rly commented May 2, 2025

Motivation

Fix #1269

How to test the behavior?

See tests

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Does the PR clearly describe the problem and the solution?
  • Have you reviewed our Contributing Guide?
  • Does the PR use "Fix #XXX" notation to tell GitHub to close the relevant issue numbered XXX when the PR is merged?

Copy link

codecov bot commented May 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.68%. Comparing base (4ea9ffa) to head (b74e2f2).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1270   +/-   ##
=======================================
  Coverage   91.68%   91.68%           
=======================================
  Files          42       42           
  Lines        9597     9598    +1     
  Branches     1933     1933           
=======================================
+ Hits         8799     8800    +1     
  Misses        519      519           
  Partials      279      279           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rly rly enabled auto-merge (squash) May 2, 2025 16:03
@rly rly requested a review from mavaylon1 May 2, 2025 16:03
@rly rly merged commit 8edb6d1 into dev May 7, 2025
25 of 26 checks passed
@rly rly deleted the get_shape_list_data branch May 7, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: get_data_shape on list of Data objects is incorrect
2 participants