add {PROVIDER}_DISPLAY_NAME env-var #8967
Conversation
n1cc00
force-pushed
the
customize-openid-login-button
branch
from
3687036 to
dbcd12d
Compare
|
Connected to Huly®: UBERF-10629 |
1 similar comment
|
Connected to Huly®: UBERF-10629 |
n1cc00
force-pushed
the
customize-openid-login-button
branch
from
510a8f6 to
112a908
Compare
| @@ -2,9 +2,12 @@ | |||
| import { Label } from '@hcengineering/ui' | |||
| import OpenId from '../icons/OpenId.svelte' | |||
| import login from '../../plugin' | |||
| import { getMetadata } from '@hcengineering/platform' | |||
|
|
|||
| const openIdDisplayName = getMetadata(login.metadata.DisableSignUp) ?? 'OpenId' | |||
There was a problem hiding this comment.
Wrong metadata being read?
There was a problem hiding this comment.
Yup. Must have hit Ctrl-Z once too much there 😄
server/front/src/starter.ts
Outdated
| @@ -119,6 +119,8 @@ export function startFront (ctx: MeasureContext, extraConfig?: Record<string, st | |||
|
|
|||
| const disableSignUp = process.env.DISABLE_SIGNUP | |||
|
|
|||
| const openIdDisplayName = process.env.OPENID_DISPLAY_NAME | |||
There was a problem hiding this comment.
Would it be better to define this variable in the accounts service along with all other variables defining the provider and return it along with the providers' ids in the /providers request? It'd help to simplify things:
- The whole provider entity is defined in one place
- Handled with one piece of code for both the web ui and the desktop
- Will also be available to any other clients besides the web ui and the desktop (e.g. automation, custom integrations, etc.)
There was a problem hiding this comment.
Makes sense. I still committed a fix for the current approach for now and will have a look into this next week
There was a problem hiding this comment.
Okay so I made a new version including it in the /providers request. I added the functionality to GitHub and google providers too for the sake of consistency (GOOGLE_DISPLAY_NAME, GITHUB_DISPLAY_NAME). Even though it probably won't really be used there.
n1cc00
force-pushed
the
customize-openid-login-button
branch
2 times, most recently
from
36b8cf2 to
7a6525f
Compare
…on (configurable via *_PROVIDER_NAME) Signed-off-by: nicolasschneider <[email protected]>
n1cc00
force-pushed
the
customize-openid-login-button
branch
from
7a6525f to
c313db2
Compare
n1cc00
changed the title
This environment variable is added to the front-service to allow setting a custom provider name for OpenId Login button: