Skip to content

Conversation

@nishaatr
Copy link
Contributor

@nishaatr nishaatr commented Oct 17, 2025

Description of change

Add Hazelcast and Management Center playbooks. This is required for How to package escrow deposit

Type of change

Select the type of change that you're making:

  • Bug fix (Addresses an issue in existing content such as a typo)
  • Enhancement (Adds new content)

Open Questions and Pre-Merge TODOs

None

@nishaatr nishaatr requested a review from a team as a code owner October 17, 2025 08:40
@nishaatr nishaatr changed the title Add Platform (v/5.6) and MC (v/5.9)playbooks Add Platform v/5.6 and MC v/5.9 playbooks [5.6.0] Oct 17, 2025
@oliverhowell
Copy link
Collaborator

Have you tried to build this locally @nishaatr ?

@nishaatr
Copy link
Contributor Author

Have you tried to build this locally @nishaatr ?

thought of it but no I am afraid.
but good suggestion so let me try.

@oliverhowell
Copy link
Collaborator

oliverhowell commented Oct 17, 2025

Worth trying - I'll give it a go after this meeting. Remember we had a page issue with the pdf so want to make sure it renders...

@nishaatr nishaatr changed the title Add Platform v/5.6 and MC v/5.9 playbooks [5.6.0] Add Platform v/5.6 and MC v/5.9 playbooks [REL-1558][5.6.0] Oct 17, 2025
@nishaatr nishaatr requested a review from oliverhowell October 17, 2025 12:10
@nishaatr
Copy link
Contributor Author

nishaatr commented Oct 17, 2025

Didn't manage to test it locally as failed to install some tools
In Jenkins we use custom Docker image with all the required tools installed
I could have run the Docker image locally but instead I customized the Python scripts (that drives the PDF creation) from a test branch to only build PDF and cloned the Jenkins build to point to this branch
The change also checks out my hazelcast-docs:add-5-6-playbooks branch

Looks like we have PDF errors after running with DEBUG and instructions on what to do next is in wiki

I will work with @oliverhowell to get the PDF errors fixed

@nishaatr
Copy link
Contributor Author

Update....

  1. PDF issues fixed in separate branch hazelcast/hz-docs@v/5.6...5-6-pdf-fix-2
  2. assembler-playbook-platform-5-6.yml now points to hz-docs:5-6-pdf-fix-2
  3. This will not be merged to main but unblocks Escrow 5.6.0 release
  4. Turns out, only needed to fix errors related to column width e.g.
    • 15:14:08 05-08-2024 14:14:07 ............INFO: asciidoctor: ERROR: 5.5@hazelcast::pdf$hazelcast-platform.adoc: line 81454: cannot fit contents of table cell into specified column width
  5. The other errors appear to be benign e.g.
    • 15:14:08 05-08-2024 14:14:07 ............INFO: asciidoctor: ERROR: 5.5@hazelcast::pdf$hazelcast-platform.adoc: line 76987: the table cell on page 1348 has been truncated; Asciidoctor PDF does not support table cell content that exceeds the height of a single page

@nishaatr nishaatr merged commit 2de1773 into main Oct 22, 2025
6 checks passed
@nishaatr nishaatr deleted the add-5-6-playbooks branch October 22, 2025 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants