Skip to content

Added if statement modification #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Conversation

oasissan
Copy link

@oasissan oasissan commented Sep 1, 2023

What I did:
Modified the code to the following, every element that has attribute (if) will be wrapped in if statement with the value of the attribute is the condition.

@haxsysgit haxsysgit self-requested a review September 9, 2023 17:09
Copy link
Owner

@haxsysgit haxsysgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi osama , thanks for the contribution but i don't think their is a html attribute like "if"
thanks for your contribution

@oasissan
Copy link
Author

Ok so basically there is no attribute called if that is the point I am targeting this attribute exactly to have no conflicts to other attributes. So you basically can add whatever attribute you want in HTML it won't throw any errors.
Lately, I found that there is an attribute called for so I changed the targeted attribute to dj-for and dj-if
I want you to check my last commit and test if it has any errors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants