Master #89
Master #89
Conversation
Added functionality for hash check when downloading files. Added functionality for folder download.
|
Ok, @antonhagg, thanks for all your work. I'll take a look. |
Fixed errors that was caused by zero files and if path to file was to long
… files from any root path Fixed havardgulldahl#103, Strange behavior when downloading file within a folder that contains "+" signs. Now it handles quotes correctly even in stream. Included functionality to download files and folders from any root path. It will preserve the hirarchy that is at the jotta servers.
| if "?mode=list" in url: #Check if we are requested a full tree of the directory | ||
| if os.path.exists('temp.xml'): | ||
| os.remove('temp.xml') | ||
| with open("temp.xml", "w") as text_file: |
There was a problem hiding this comment.
Could you update this to use tempfile.NamedTemporaryFile() instead?
There was a problem hiding this comment.
Should be possible. It has been good to have the xml for debugging.
Had some issues with Incomplete files so have done some changes to fix this
Closes #119 closes #73 closes #78 Thanks a million, @antonhagg
|
So, @antonhagg, I have gone through the code now feature by feature, and added everything and rewrote parts of it. May I suggest next time you keep your commits to one feature at a time? It makes it much easier to follow both how your patch evolved, and to pull in your stuff. But don't take this the wrong way. I really appreciate your time. Please keep contributing, your efforts are really helpful 👍 |
|
Wow, cool! =) I appriciate the feedback, in still learing. =) |
Added functionality for folder download.
Added functionality for hash checking when downloading.
Resolve #72
Resolve #73
Resolve #78
Resolve #85
Resolve #86
Resolve #87
Resolve #88