Improve test coverage #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #10 +/- ##
============================================
- Coverage 100.00% 77.27% -22.73%
============================================
Files 4 5 +1
Lines 59 132 +73
============================================
+ Hits 59 102 +43
- Misses 0 30 +30
Continue to review full report at Codecov.
|
hassansalehe
commented
Jun 26, 2021
test/Common_Instruction_gtest.cc
Outdated
| #include "common/instruction.h" | ||
|
|
||
| // TEST(TestInstruction, TestConversion) { | ||
| // } |
There was a problem hiding this comment.
Remove commented out code. It does not add any value.
hassansalehe
commented
Jun 26, 2021
test/Common_Instruction_gtest.cc
Outdated
| // TEST(TestInstruction, TestConversion) { | ||
| // } | ||
|
|
||
| TEST(TestInstruction, TestTrimHelperFunction) { |
There was a problem hiding this comment.
Think about improving test names. Why does each test start with Test?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.