-
Notifications
You must be signed in to change notification settings - Fork 38
Remove no longer building buster based images from CI config #157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
902bc6d
feat: bump ghc 9.10 to 9.10.2
jhrcek 0e18fa3
Use Zubin's GPG key
jhrcek 0fc4962
Remove all buster based images from CI config
jhrcek 11bf04b
Undo 9.10.2 changes
jhrcek 848f659
Update debian.yml
develop7 c006379
Revert "Update debian.yml"
develop7 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -26,50 +26,26 @@ jobs: | |
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| ghc: ['9.12.2', '9.10.1', '9.8.4', '9.6.7', '9.4.8', '9.2.8', '9.0.2'] | ||
| deb: ['buster', 'slim-buster'] | ||
develop7 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| ghc: ['9.12.2', '9.10.2', '9.8.4', '9.6.7'] | ||
| deb: ['bullseye', 'slim-bullseye'] | ||
|
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Since Buster is no longer buildable, switching the "default" debian to the next release which is still supported. |
||
| include: | ||
| - ghc: '9.12.2' | ||
| ghc_minor: '9.12' | ||
| deb: 'bookworm' | ||
| - ghc: '9.12.2' | ||
| ghc_minor: '9.12' | ||
| deb: 'slim-bookworm' | ||
| - ghc: '9.10.1' | ||
| - ghc: '9.10.2' | ||
| ghc_minor: '9.10' | ||
| deb: 'slim-bullseye' | ||
| - ghc: '9.10.1' | ||
| ghc_minor: '9.10' | ||
| deb: 'bullseye' | ||
| - ghc: '9.10.1' | ||
| ghc_minor: '9.10' | ||
| - ghc: '9.8.4' | ||
| ghc_minor: '9.8' | ||
| deb: 'slim-bullseye' | ||
| - ghc: '9.8.4' | ||
| ghc_minor: '9.8' | ||
| deb: 'bullseye' | ||
| - ghc: '9.8.4' | ||
| ghc_minor: '9.8' | ||
| - ghc: '9.6.7' | ||
| ghc_minor: '9.6' | ||
| deb: 'slim-bullseye' | ||
| - ghc: '9.6.7' | ||
| ghc_minor: '9.6' | ||
| deb: 'bullseye' | ||
| - ghc: '9.6.7' | ||
| ghc_minor: '9.6' | ||
| - ghc: '9.4.8' | ||
| ghc_minor: '9.4' | ||
| - ghc: '9.2.8' | ||
| ghc_minor: '9.2' | ||
| - ghc: '9.0.2' | ||
| ghc_minor: '9.0' | ||
| exclude: | ||
| - ghc: '9.12.2' | ||
| deb: 'buster' | ||
| deb: 'bullseye' | ||
develop7 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| - ghc: '9.12.2' | ||
| deb: 'slim-buster' | ||
| deb: 'slim-bullseye' | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - name: build + smoke test [${{ matrix.ghc }}] | ||
|
|
@@ -96,9 +72,9 @@ jobs: | |
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| ghc: ['9.0.2', '9.2.8', '9.4.8', '9.6.7', '9.8.4', '9.10.1', '9.12.2'] | ||
| ghc: ['9.6.7', '9.8.4', '9.10.2', '9.12.2'] | ||
| # uraimo/run-on-arch-action does not support debian slim variants | ||
| deb: ['buster'] | ||
| deb: ['bullseye'] | ||
| arch: ['aarch64'] | ||
| include: | ||
| # bookworm (debian 12) | ||
|
|
@@ -108,39 +84,18 @@ jobs: | |
| arch: 'aarch64' | ||
| docker_platform: arm64 | ||
| # bullseye (debian 11) | ||
| - ghc: '9.10.1' | ||
| - ghc: '9.10.2' | ||
| ghc_minor: '9.10' | ||
| deb: 'bullseye' | ||
| arch: 'aarch64' | ||
| docker_platform: arm64 | ||
| - ghc: '9.8.4' | ||
| ghc_minor: '9.8' | ||
| deb: 'bullseye' | ||
| arch: 'aarch64' | ||
| docker_platform: arm64 | ||
| - ghc: '9.6.7' | ||
| ghc_minor: '9.6' | ||
| deb: 'bullseye' | ||
| arch: 'aarch64' | ||
| docker_platform: arm64 | ||
| # buster (debian 10) | ||
| - ghc: '9.10.1' | ||
| ghc_minor: '9.10' | ||
| - ghc: '9.8.4' | ||
| ghc_minor: '9.8' | ||
| - ghc: '9.6.7' | ||
| ghc_minor: '9.6' | ||
| - ghc: '9.4.8' | ||
| ghc_minor: '9.4' | ||
| - ghc: '9.2.8' | ||
| ghc_minor: '9.2' | ||
| - ghc: '9.0.2' | ||
| ghc_minor: '9.0' | ||
| - arch: aarch64 | ||
| docker_platform: arm64 | ||
| exclude: | ||
develop7 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| - ghc: '9.12.2' | ||
| deb: 'buster' | ||
| deb: 'bullseye' | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v4 | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing all older GHCs from here, as those only have Buster based images that no longer build.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Um, you could still use older bindists on newer debian. Worked for aarch64 before, must work for x86_64. anyway, it's beyond the scope of this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think most of the haskell community is on ghc 9.6.7+.
I would prefer not adding older GHCs with newer debians unless there's popular demand for it.