Repository navigation
Expand ${pkgroot} variable when reading haddock-html field from ghc-pkg - #11218
Merged
Merged
Conversation
mpickering
changed the title
mpickering
force-pushed
the
wip/fix-pkgroot-haddock-html
branch
from
September 16, 2025 15:58
703b36f to
31e3f33
Compare
geekosaur
requested changes
Sep 16, 2025
alt-romes
approved these changes
Sep 17, 2025
|
What's required to get this merged? While simple, this is an important fix for |
Collaborator
|
We're waiting on @mpickering (ping!) to respond to a change request. |
mpickering
force-pushed
the
wip/fix-pkgroot-haddock-html
branch
2 times, most recently
from
January 20, 2026 14:37
454d51a to
6da926e
Compare
This fixes #11217 No test, as it is difficult to test since you need to: 1. Ensure there is a package registration with ${pkgroot} 2. Check the existence of a certain link in the generated HTML.
mpickering
force-pushed
the
wip/fix-pkgroot-haddock-html
branch
from
January 20, 2026 14:43
6da926e to
423ce6c
Compare
Collaborator
Author
|
@geekosaur I've fixed the changelog entry now, would you be able to approve? |
geekosaur
approved these changes
Jan 22, 2026
Collaborator
|
@LightAndLight, would you like to set the |
|
I can't change the label (not a maintainer) |
Collaborator
Author
|
I've added the label. |
mergify
Bot
added
ready and waiting
Contributor
Merge Queue Status✅ The pull request has been merged at 423ce6c This pull request spent 1 hour 57 minutes 56 seconds in the queue, including 1 hour 47 minutes 35 seconds running CI. Required conditions to merge
|
This was referenced Jan 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #11217
No test, as it is difficult to test since you need to:
Manual QA: Inspect the output of running
cabal haddockon a package and notice the links to base documentation work.Please read Github PR Conventions and then fill in one of these two templates.
Template Α: This PR modifies behaviour or interface
Include the following checklist in your PR:
significance: significantin the changelog file.Template B: This PR does not modify behaviour or interface
E.g. the PR only touches documentation or tests, does refactorings, etc.
Include the following checklist in your PR: