Remove text for sandbox in replCommand #10493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geekosaur
approved these changes
Oct 30, 2024
Collaborator
geekosaur
left a comment
geekosaur
left a comment
There was a problem hiding this comment.
This is user-visible (granting, not very, but it is help text) and as such probably requires a changelog entry, although it's not major. Also it's probably worth backporting.
ulysses4ever
approved these changes
Oct 30, 2024
ulysses4ever
added
merge me
Collaborator
|
I'm not sure about the changelog but since technically it is a visible change and there's a voice for it, sure... |
Collaborator
|
Changelogs are described here btw: https://github.com/haskell/cabal/blob/master/CONTRIBUTING.md#changelog |
Collaborator
Yeh, it's borderline, but it is user-visible. Maybe someone else should speak up yea/nay. |
Contributor
Author
|
Thx for reminding me. I will check CONTRIBUTING.md and add changelog entry. |
mergify
bot
added
ready and waiting
Mikolaj
force-pushed
the
doc-refine/repl
branch
from
c6f92a9 to
5913791
Compare
Member
|
@mergify backport 3.14 |
Contributor
✅ Backports have been createdDetails
|
5 tasks
mergify bot
added a commit
that referenced
this pull request
Mar 27, 2025
* remove text for sandbox in replCommand (cherry picked from commit e3823b5) * delete white-space after '\n' in a string (cherry picked from commit bdeb4e6) * Add changelog (cherry picked from commit 5913791) --------- Co-authored-by: Sdywolf <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies behaviour or interface
Fix #10482
Text provided by
Setup.hs repl --helpcontained outdated information concerning sandbox, which have now been removed.