Default to exiting with success if the check run is successful #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Towards clarification of warden's place in the pipeline in #165 - warden shouldn't be making the "go/no-go" call on the dataset itself but should be generating metadata such that something else can make the decision. As part of this, we don't want jobs to fail/abort with error if the checks in fact ran successfully.
|
👍 |
|
Wonder if a summary of errors is useful for warden, similar to what |
|
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards clarification of warden's place in the pipeline in #165 -
warden shouldn't be making the "go/no-go" call on the dataset itself
but should be generating metadata such that something else can make
the decision. As part of this, we don't want jobs to fail/abort with
error if the checks in fact ran successfully.
! @erikd-ambiata @thumphries
/jury approved @thumphries @erikd-ambiata