Add traverse path filter for Linux#112
Open
gjz010 wants to merge 3 commits intohaskell-fswatch:masterfrom
Open
Add traverse path filter for Linux#112gjz010 wants to merge 3 commits intohaskell-fswatch:masterfrom
gjz010 wants to merge 3 commits intohaskell-fswatch:masterfrom
Conversation
… only. Use fromRawFilePath.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the implementation of FSNotify on Linux traverses through all subdirectories and call
INo.addWatch(inotify_add_watch) recursively on all directories. This crashes applications when a really unwanted directory (for example, one containing broken symlinks) is scanned, and may cause performance problems.(See srid/unionmount#9 , where
.direnvand therefore a wholenixpkgsis scanned.)In this patch, a
confPathFilteris added toWatchConfigto allow users to hold the library back from traversing down unwanted directories.