fix: adjust post html markup for safari's reader#831
Conversation
df46091 to
4de90da
Compare
4de90da to
3197c40
Compare
mode * rework html markup by removing extra section tag and replacing h1 with header * fixes css that was broken by changes to structure * add structured data so browser can infer things like markup, type, title, and author
3197c40 to
7ac3e55
Compare
|
@jwworth This should fix the reader mode issue. Could I trouble you for a quick once over on staging? If you need credentials, I can provide those in the alumni slack. |
|
I did a final pre-deploy test in staging today and there's something not quite right. I'm having a hard time telling if it's this change or a recent change to iOS/Safari. I could definitely use some help here. On Mobile Safari (iOS 18.4.1), the Reader Mode option is no longer showing in the toolbar. There is an option to automatically enable Reader Mode on certain webpages. Toggling this for TIL and refreshing the page does nothing. Still can't see anything in Reader Mode. However, if I scroll to the bottom of the feed and click "Older TILs", Reader Mode does become available, but only for a single, large-ish, TIL in the feed - "Delete a Command from ZSH history". On Desktop Safari (Sequoia 15.3.2), toggling Reader Mode only summarizes 1 TIL in the feed, ALL Caps SQL, which is another longer winded TIL. Some notes -
|
I'm sorry I missed this, @avogel3! Thanks for doing this work. I can test something out in a staging environment if needed. And FWIW I can still view TIL in Reader Mode on iOS and MacOS. But since it's been a while, feel free to close my issue and label it "won't fix." I doubt many readers are affected, and there is a simple workaround. |
fixes #830