Add optional namespace override to KV tools#115
Open
jm-merchan wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds per-call Vault namespace override support to KV tools so callers can target a specific Vault namespace without changing the MCP session default.
Changes:
- Added a new optional
namespacestring parameter to read/write/list/delete KV tools. - Applied the namespace override to the Vault client before performing KV operations.
- Introduced a small helper to apply the namespace only when provided.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/tools/kv/write_secret.go | Adds namespace tool argument and applies optional namespace to Vault client. |
| pkg/tools/kv/read_secret.go | Adds namespace tool argument and applies optional namespace to Vault client. |
| pkg/tools/kv/list_secrets.go | Adds namespace tool argument and applies optional namespace to Vault client. |
| pkg/tools/kv/delete_secret.go | Adds namespace tool argument and applies optional namespace to Vault client. |
| pkg/tools/kv/namespace.go | New helper to apply an optional Vault namespace to the client. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+12
to
+18
| func withOptionalNamespace(vault *api.Client, namespace string) *api.Client { | ||
| ns := strings.TrimSpace(namespace) | ||
| if ns == "" { | ||
| return vault | ||
| } | ||
| return vault.WithNamespace(ns) | ||
| } No newline at end of file |
Comment on lines
+33
to
+36
| mcp.WithString("namespace", | ||
| mcp.DefaultString(""), | ||
| mcp.Description("Optional Vault namespace override for this call (for example: 'admin/team-03'). If not set, uses the MCP session namespace."), | ||
| ), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an optional parameter to the existing KV tools so callers can target a different Vault namespace per request without changing the MCP session namespace.
Changes
Why
This supports multi-namespace workflows from a single MCP session and avoids having to reconfigure the server between calls.
Validation