builder/googlecompute: added support for all standard VM images #1350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixed the error message to be clear that the image was not found in any of the projects that we attempted to search, rather than keep the error message from the last project, which may be confusing to users.
| @@ -229,7 +229,7 @@ func (d *driverGCE) WaitForInstance(state, zone, name string) <-chan error { | |||
| } | |||
|
|
|||
| func (d *driverGCE) getImage(name string) (image *compute.Image, err error) { | |||
| projects := []string{d.projectId, "debian-cloud", "centos-cloud"} | |||
| projects := []string{d.projectId, "centos-cloud", "debian-cloud", "google-containers", "rhel-cloud", "suse-cloud"} | |||
There was a problem hiding this comment.
Looks like there may be a few others that could be added to the list. [https://developers.google.com/compute/docs/operating-systems]
|
Thanks @mbrukman! |
erjohnso
added a commit
that referenced
this pull request
Jul 25, 2014
builder/googlecompute: added support for all standard VM images
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixed the error message to be clear that the image was not found in any of
the projects that we attempted to search, rather than keep the error message
from the last project, which may be confusing to users.