-
Notifications
You must be signed in to change notification settings - Fork 51
AppFooter
- Update copyright text (HDS-5553)
#3314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
packages/components/translations/hds/components/app-footer/copyright/en-us.yaml
Outdated
Show resolved
Hide resolved
This comment was marked as resolved.
This comment was marked as resolved.
caf8830
to
2fb6d8f
Compare
Co-authored-by: Dylan Hyun <[email protected]>
@KristinLBradley FYI there is already a PR opened by @DanielChenTO #3309 which is still incomplete (see @alex-ju comment here #3309 (review)); can you sync with them and see what is the best way forward to avoid duplicate/conflicting efforts? |
@didoo I added a comment suggesting that they close their PR in favor of this one. I went ahead and closed the other PR together with leaving another comment to let them know. |
packages/components/src/components/hds/app-footer/copyright.hbs
Outdated
Show resolved
Hide resolved
packages/components/translations/hds/components/app-footer/copyright/en-us.yaml
Outdated
Show resolved
Hide resolved
Update capitalization
131a048
packages/components/src/components/hds/app-footer/copyright.hbs
Outdated
Show resolved
Hide resolved
Co-authored-by: Jory Tindall <[email protected]>
📌 Summary
If merged, this PR updates the
AppFooter
copyright text from "HashiCorp" to "HashiCorp, an IBM Company"Preview: https://hds-showcase-git-hds-5553-app-footer-copyright-update-hashicorp.vercel.app/components/app-footer
📸 Screenshots
Styles were added so that copyright content will wrap and center in smaller viewports. (When only the text was updated, the layout together with the logo wrapped awkwardly.)
🔗 External links
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.
📋 PCI review checklist
Examples of changes to controls include access controls, encryption, logging, etc.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.