CodeBlock gts conversion
#3293
Merged
CodeBlock gts conversion
#3293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
zamoore
force-pushed
the
zamoore/hds-5336/code-block-gts
branch
from
e4b307b to
ead3099
Compare
shleewhite
reviewed
Oct 10, 2025
|
|
||
| <ShwDivider @level={{2}} /> | ||
|
|
||
| <ShwTextH3>Dynamic content</ShwTextH3> |
There was a problem hiding this comment.
Suggestion: I would make this one a code fragment, just to group the functionality code closer to the template code. But you dont have to.
There was a problem hiding this comment.
I think I'm going to leave it here for now because it's a small block and not reusable. If that's alright.
showcase/app/components/page-components/code-block/sub-sections/demo.gts
Outdated
Show resolved
Hide resolved
zamoore
force-pushed
the
zamoore/hds-5336/code-block-gts
branch
from
ead3099 to
b3f04f0
Compare
shleewhite
previously approved these changes
Oct 17, 2025
zamoore
force-pushed
the
zamoore/hds-5336/code-block-gts
branch
from
b3f04f0 to
106a1f2
Compare
|
@zamoore it seems like the indentation on some of the examples got messed up which got caught by Percy, otherwise PR is looking good. |
zamoore
force-pushed
the
zamoore/hds-5336/code-block-gts
branch
from
3ee7a3c to
1e99e60
Compare
shleewhite
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
If merged, this PR converts the CodeBlock showcase page to a GTS component.
🔗 External links
Jira ticket: HDS-5336
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.
📋 PCI review checklist
Examples of changes to controls include access controls, encryption, logging, etc.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.