Skip to content

(configurable VIP) added new config to configure virtual ip CIDRs in t-proxy #23085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sujay-hashicorp wants to merge 1 commit into
base: main
Choose a base branch
from
Open

(configurable VIP) added new config to configure virtual ip CIDRs in t-proxy #23085

sujay-hashicorp wants to merge 1 commit into from
+254 −25

Conversation

@sujay-hashicorp
Copy link
Contributor

@sujay-hashicorp sujay-hashicorp commented Nov 30, 2025 •
edited
Loading

Description

This is to address: #22595

Testing & Reproduction steps

Default Config for Service Mesh
connect {
  enabled = true
}
Screenshot 2025-12-01 at 03 04 13
Defined IPv4 CIDR for Virtual IP assignment
connect {
  enabled = true
  # Override default 240.0.0.0/4 virtual IP range for transparent proxy
  virtual_ip_cidr = "240.10.0.0/16"
  # virtual_ip_cidr_v6 = "..." # to define IPv6 CIDR
}
Screenshot 2025-12-01 at 14 59 28

Links

n/a

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

PCI review checklist

  • I have documented a clear reason for, and description of, the change I am making.

  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.

  • If applicable, I've documented the impact of any changes to security controls.

    Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.

@sujay-hashicorp sujay-hashicorp added the backport/all Apply backports for all active releases per .release/versions.hcl label Nov 30, 2025
@github-actions github-actions bot added the theme/config Relating to Consul Agent configuration, including reloading label Nov 30, 2025
@sujay-hashicorp sujay-hashicorp marked this pull request as ready for review December 1, 2025 05:07
@sujay-hashicorp sujay-hashicorp requested review from a team as code owners December 1, 2025 05:07
@sujay-hashicorp sujay-hashicorp force-pushed the sujay/dev/configurevip branch 4 times, most recently from ba3d1f5 to 9fc34ab Compare December 1, 2025 07:17
@sujay-hashicorp sujay-hashicorp added backport/1.22 Changes are backported to 1.22 and removed backport/all Apply backports for all active releases per .release/versions.hcl labels Dec 3, 2025
sreeram77
sreeram77 requested changes Dec 4, 2025
View reviewed changes
agent/config/builder.go
ConnectMeshGatewayWANFederationEnabled: connectMeshGatewayWANFederationEnabled,
ConnectSidecarMinPort: sidecarMinPort,
ConnectSidecarMaxPort: sidecarMaxPort,
ConnectVirtualIPCIDR: connectVirtualIPCIDR,
Copy link
Member

@sreeram77 sreeram77 Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we name this as ConnectVirtualIPCIDRv4 to be explicit?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sreeram77 sreeram77 sreeram77 requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

backport/1.22 Changes are backported to 1.22 theme/config Relating to Consul Agent configuration, including reloading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sujay-hashicorp @sreeram77