-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(multi-cluster): add the ability to specify inside which cluster to add new node with solo node add #1687
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Zhan Milenkov <[email protected]>
Signed-off-by: Zhan Milenkov <[email protected]>
Signed-off-by: Zhan Milenkov <[email protected]>
Signed-off-by: Zhan Milenkov <[email protected]>
…-to-specify-inside-which-cluster-to-add-new-node-with-solo-node-add
Signed-off-by: Zhan Milenkov <[email protected]>
Signed-off-by: Zhan Milenkov <[email protected]>
Signed-off-by: Zhan Milenkov <[email protected]>
Signed-off-by: Zhan Milenkov <[email protected]>
…-to-specify-inside-which-cluster-to-add-new-node-with-solo-node-add
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1687 +/- ##
==========================================
+ Coverage 84.77% 84.87% +0.09%
==========================================
Files 203 203
Lines 30299 30402 +103
Branches 2074 2091 +17
==========================================
+ Hits 25687 25804 +117
+ Misses 4509 4485 -24
- Partials 103 113 +10
🚀 New features to boost your workflow:
|
…-to-specify-inside-which-cluster-to-add-new-node-with-solo-node-add
…ands ( add, delete and update ) in separate methods instead of one big combined conditional logic Signed-off-by: Zhan Milenkov <[email protected]>
…-to-specify-inside-which-cluster-to-add-new-node-with-solo-node-add
Signed-off-by: Zhan Milenkov <[email protected]>
Signed-off-by: Zhan Milenkov <[email protected]>
Signed-off-by: Zhan Milenkov <[email protected]>
Description
--cluster-ref
tonode add
commands.index
of the node inside the helm chart is figured outRelated Issues