Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(multi-cluster): add the ability to specify inside which cluster to add new node with solo node add #1687

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

instamenta
Copy link
Contributor

@instamenta instamenta commented Mar 20, 2025

Description

  • Adds optional flag --cluster-ref to node add commands.
  • Changes the way that index of the node inside the helm chart is figured out

Related Issues

Copy link
Contributor

github-actions bot commented Mar 20, 2025

Unit Test Results - Linux

  1 files  ±0   72 suites  ±0   2s ⏱️ -1s
301 tests ±0  301 ✅ ±0  0 💤 ±0  0 ❌ ±0 
306 runs  ±0  306 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 69b36f3. ± Comparison against base commit cfbf96f.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Mar 20, 2025

Unit Test Results - Windows

  1 files  ±0   72 suites  ±0   4s ⏱️ -1s
301 tests ±0  301 ✅ ±0  0 💤 ±0  0 ❌ ±0 
306 runs  ±0  306 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 69b36f3. ± Comparison against base commit cfbf96f.

♻️ This comment has been updated with latest results.

Signed-off-by: Zhan Milenkov <[email protected]>
…-to-specify-inside-which-cluster-to-add-new-node-with-solo-node-add
Signed-off-by: Zhan Milenkov <[email protected]>
Signed-off-by: Zhan Milenkov <[email protected]>
Signed-off-by: Zhan Milenkov <[email protected]>
…-to-specify-inside-which-cluster-to-add-new-node-with-solo-node-add
@instamenta instamenta marked this pull request as ready for review March 21, 2025 15:37
@instamenta instamenta requested a review from a team as a code owner March 21, 2025 15:37
@instamenta instamenta added the PR: Needs Team Approval A pull request that needs review from a team member. label Mar 21, 2025
Copy link
Contributor

E2E Test Report

 18 files  ±0  124 suites  ±0   1h 28m 44s ⏱️ - 1m 53s
311 tests ±0  311 ✅ ±0  0 💤 ±0  0 ❌ ±0 
328 runs  ±0  328 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit d506490. ± Comparison against base commit f399d3c.

Copy link
Contributor

github-actions bot commented Mar 21, 2025

E2E Test Report

 18 files  ±0  124 suites  ±0   1h 29m 34s ⏱️ +26s
311 tests ±0  311 ✅ ±0  0 💤 ±0  0 ❌ ±0 
328 runs  ±0  328 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 69b36f3. ± Comparison against base commit cfbf96f.

♻️ This comment has been updated with latest results.

Copy link

codacy-production bot commented Mar 21, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.08% (target: -1.00%) 87.45%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (cfbf96f) 30299 25992 85.79%
Head commit (69b36f3) 30402 (+103) 26104 (+112) 85.86% (+0.08%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1687) 231 202 87.45%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Mar 21, 2025

Codecov Report

Attention: Patch coverage is 87.44589% with 29 lines in your changes missing coverage. Please review.

Project coverage is 84.87%. Comparing base (cfbf96f) to head (69b36f3).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/commands/node/tasks.ts 86.63% 29 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1687      +/-   ##
==========================================
+ Coverage   84.77%   84.87%   +0.09%     
==========================================
  Files         203      203              
  Lines       30299    30402     +103     
  Branches     2074     2091      +17     
==========================================
+ Hits        25687    25804     +117     
+ Misses       4509     4485      -24     
- Partials      103      113      +10     
Files with missing lines Coverage Δ
src/commands/node/configs.ts 89.14% <100.00%> (+0.03%) ⬆️
src/commands/node/flags.ts 100.00% <100.00%> (ø)
src/commands/node/handlers.ts 90.57% <100.00%> (ø)
src/commands/node/tasks.ts 92.55% <86.63%> (+0.75%) ⬆️

... and 14 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…-to-specify-inside-which-cluster-to-add-new-node-with-solo-node-add
…ands ( add, delete and update ) in separate methods instead of one big combined conditional logic

Signed-off-by: Zhan Milenkov <[email protected]>
…-to-specify-inside-which-cluster-to-add-new-node-with-solo-node-add
Signed-off-by: Zhan Milenkov <[email protected]>
Signed-off-by: Zhan Milenkov <[email protected]>
@instamenta instamenta requested a review from nathanklick March 21, 2025 19:53
@Ivo-Yankov Ivo-Yankov added PR: Needs Manager Approval A pull request that needs review from a manager. and removed PR: Needs Team Approval A pull request that needs review from a team member. labels Mar 24, 2025
@jeromy-cannon jeromy-cannon added the PR: Merge Conflicts A pull request that has merge conflicts that need to be resolved. label Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Merge Conflicts A pull request that has merge conflicts that need to be resolved. PR: Needs Manager Approval A pull request that needs review from a manager.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the ability to specify inside which cluster to add new node with 'solo node add'
3 participants