feat(cli): need to allow the user to pass in the domain name for mirror node, explorer, relay, and node service endpoints #1673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zhan Milenkov <[email protected]>
…y' and 'solo mirror-node deploy' Signed-off-by: Zhan Milenkov <[email protected]>
…he-user-to-pass-in-the-domain-name-to-use-for-mirror-node-mirror-node-explorer-and-service-endpoints
…ded it to 'solo network deploy' + all the 'solo node commands' where they are used Signed-off-by: Zhan Milenkov <[email protected]>
…he-user-to-pass-in-the-domain-name-to-use-for-mirror-node-mirror-node-explorer-and-service-endpoints
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1673 +/- ##
==========================================
- Coverage 84.25% 84.24% -0.02%
==========================================
Files 212 212
Lines 31307 31371 +64
Branches 2838 2168 -670
==========================================
+ Hits 26378 26427 +49
- Misses 4740 4817 +77
+ Partials 189 127 -62
... and 69 files with indirect coverage changes 🚀 New features to boost your workflow:
|
…he-user-to-pass-in-the-domain-name-to-use-for-mirror-node-mirror-node-explorer-and-service-endpoints # Conflicts: # src/commands/mirror-node.ts
Signed-off-by: Zhan Milenkov <[email protected]>
Signed-off-by: instamenta <[email protected]>
Signed-off-by: Zhan Milenkov <[email protected]>
…pass-in-the-domain-name-to-use-for-mirror-node-mirror-node-explorer-and-service-endpoints' into 01040-need-to-allow-the-user-to-pass-in-the-domain-name-to-use-for-mirror-node-mirror-node-explorer-and-service-endpoints
Signed-off-by: Zhan Milenkov <[email protected]>
…he-user-to-pass-in-the-domain-name-to-use-for-mirror-node-mirror-node-explorer-and-service-endpoints # Conflicts: # src/commands/explorer.ts # src/commands/mirror-node.ts # src/commands/network.ts # src/commands/node/flags.ts
…pass-in-the-domain-name-to-use-for-mirror-node-mirror-node-explorer-and-service-endpoints' into 01040-need-to-allow-the-user-to-pass-in-the-domain-name-to-use-for-mirror-node-mirror-node-explorer-and-service-endpoints
…esting Signed-off-by: instamenta <[email protected]>
… fixed the taskfile solo:explorer:deploy and added new taskfile for testing connection when providing domain names to solo Signed-off-by: instamenta <[email protected]>
Signed-off-by: instamenta <[email protected]>
Signed-off-by: instamenta <[email protected]>
…he-user-to-pass-in-the-domain-name-to-use-for-mirror-node-mirror-node-explorer-and-service-endpoints # Conflicts: # src/commands/node/configs.ts # src/commands/node/node-add-config.ts
…node Signed-off-by: instamenta <[email protected]>
Signed-off-by: instamenta <[email protected]>
instamenta
changed the title
Signed-off-by: instamenta <[email protected]>
jeromy-cannon
approved these changes
Mar 27, 2025
jeromy-cannon
added
the
PR: Ready to Merge
instamenta
deleted the
01040-need-to-allow-the-user-to-pass-in-the-domain-name-to-use-for-mirror-node-mirror-node-explorer-and-service-endpoints
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds new flags:
--domain-name- for specifying domain name on:solo mirror-node deploysolo explorer deploysolo relay deploy--domain-names- for specifying deployment names for consensus nodes whengenesis-network.yamlandconfig.txtare being built.Related Issues