Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: move test scripts from 'package.json' to 'Taskfile' #1485

Merged
merged 68 commits into from
Apr 2, 2025
Merged

chore: move test scripts from 'package.json' to 'Taskfile' #1485

merged 68 commits into from
Apr 2, 2025

Conversation

instamenta
Copy link
Contributor

@instamenta instamenta commented Feb 25, 2025 •
edited
Loading

Description

Scripts related to running tests are moved from "scripts" inside the root package.json to the root Taskfile.yml

Related Issues

@instamenta instamenta self-assigned this Feb 25, 2025
@instamenta instamenta requested review from a team as code owners February 25, 2025 12:50
@instamenta instamenta linked an issue Feb 25, 2025 that may be closed by this pull request
move package.json scripts into Taskfile to clean it up and make it less complex #1073
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 25, 2025 •
edited
Loading

Unit Test Results - Linux

24 tests  ±0   24 ✅ ±0   0s ⏱️ ±0s
13 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 096a05f. ± Comparison against base commit 8e8606c.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 25, 2025 •
edited
Loading

Unit Test Results - Windows

  1 files  ±0   70 suites  ±0   2s ⏱️ ±0s
289 tests ±0  289 ✅ ±0  0 💤 ±0  0 ❌ ±0 
294 runs  ±0  294 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 096a05f. ± Comparison against base commit 8e8606c.

♻️ This comment has been updated with latest results.

@jeromy-cannon jeromy-cannon added the PR: Merge Conflicts A pull request that has merge conflicts that need to be resolved. label Feb 25, 2025
@instamenta
disconnected taskfile example with the taskfile helper
6124dcf 
Signed-off-by: Zhan Milenkov <[email protected]>
@instamenta
Merge remote-tracking branch 'origin/main' into 01073-move-packagejso…
ba62174 
…n-scripts-into-taskfile-to-clean-it-up-and-make-it-less-complex

# Conflicts:
#	.github/workflows/zxc-e2e-test.yaml
@instamenta
add non migrated piece of code
cbfd32c 
Signed-off-by: Zhan Milenkov <[email protected]>
@instamenta instamenta added PR: Checks Failed A pull request where the checks have failed. and removed PR: Merge Conflicts A pull request that has merge conflicts that need to be resolved. labels Feb 25, 2025
andrewb1269hg
andrewb1269hg previously approved these changes Feb 25, 2025
View reviewed changes
Copy link
Contributor

@andrewb1269hg andrewb1269hg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review and approve .yaml files assigned to Platform CI Team.

@jeromy-cannon jeromy-cannon added the PR: Merge Conflicts A pull request that has merge conflicts that need to be resolved. label Feb 26, 2025
JeffreyDallas
JeffreyDallas reviewed Mar 31, 2025
View reviewed changes
jeromy-cannon
jeromy-cannon reviewed Mar 31, 2025
View reviewed changes
@jeromy-cannon
Copy link
Contributor

@instamenta , also Deploy Hugo site to Pages / Build (pull_request) failed with:

2025-03-31T14:55:36.8656460Z task: Failed to run task "default": task: Maximum task call exceeded (1000) for task "build": probably an cyclic dep or infinite loop

@instamenta instamenta removed the PR: Needs Team Approval A pull request that needs review from a team member. label Mar 31, 2025
@instamenta
Merge remote-tracking branch 'origin/main' into 01073-move-packagejso…
68dfb67 
…n-scripts-into-taskfile-to-clean-it-up-and-make-it-less-complex

# Conflicts:
#	src/data/schema/migration/api/schema-base.ts
@instamenta
moved tests to new Taskfile.tests.yml and moved the post-install scri…
1fd83ce 
…pt to package.json

Signed-off-by: Zhan Milenkov <[email protected]>
@instamenta
finish moving scripts from old taskfile helpers inside the taskfile e…
a38e26e 
…xamples in the examples folder

Signed-off-by: Zhan Milenkov <[email protected]>
@instamenta instamenta marked this pull request as draft April 1, 2025 10:04
@instamenta
fix hugo pages taskfile
05d3a87 
Signed-off-by: Zhan Milenkov <[email protected]>
@instamenta
fix path
44b6a90 
Signed-off-by: Zhan Milenkov <[email protected]>
@instamenta instamenta marked this pull request as ready for review April 1, 2025 11:16
@instamenta instamenta added the PR: Needs Team Approval A pull request that needs review from a team member. label Apr 1, 2025
jeromy-cannon
jeromy-cannon reviewed Apr 1, 2025
View reviewed changes
@jeromy-cannon jeromy-cannon added PR: Unresolved Comments A pull request where there are comments and they need to be resolved. and removed PR: Needs Team Approval A pull request that needs review from a team member. labels Apr 1, 2025
@instamenta
dont import the Taskfile.examples.yml inside the root/Taskfile.yml
075ea0c 
Signed-off-by: Zhan Milenkov <[email protected]>
@instamenta
add build script to root/Taskfile.yml
08e9bbf 
Signed-off-by: Zhan Milenkov <[email protected]>
@instamenta
fix path
6a70edb 
Signed-off-by: Zhan Milenkov <[email protected]>
@instamenta
Merge remote-tracking branch 'origin/main' into 01073-move-packagejso…
06bfa15 
…n-scripts-into-taskfile-to-clean-it-up-and-make-it-less-complex

# Conflicts:
#	Taskfile.helper.yml
@instamenta
fix merge issues
4bd937e 
Signed-off-by: Zhan Milenkov <[email protected]>
@instamenta instamenta added PR: Needs Team Approval A pull request that needs review from a team member. PR: Needs Manager Approval A pull request that needs review from a manager. and removed PR: Unresolved Comments A pull request where there are comments and they need to be resolved. labels Apr 2, 2025
@instamenta
Merge remote-tracking branch 'origin/main' into 01073-move-packagejso…
3faf842 
…n-scripts-into-taskfile-to-clean-it-up-and-make-it-less-complex

# Conflicts:
#	.github/workflows/flow-build-application.yaml
#	.github/workflows/flow-pull-request-checks.yaml
#	package.json
@instamenta
fix merge issues and remove mirror-node tests
096a05f 
Signed-off-by: Zhan Milenkov <[email protected]>
@jeromy-cannon jeromy-cannon merged commit beec381 into main Apr 2, 2025
45 checks passed
@jeromy-cannon jeromy-cannon deleted the 01073-move-packagejson-scripts-into-taskfile-to-clean-it-up-and-make-it-less-complex branch April 2, 2025 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeromy-cannon jeromy-cannon jeromy-cannon approved these changes

@andrewb1269hg andrewb1269hg andrewb1269hg left review comments

@nathanklick nathanklick Awaiting requested review from nathanklick nathanklick is a code owner automatically assigned from hashgraph/release-engineering-managers

@rbarker-dev rbarker-dev Awaiting requested review from rbarker-dev rbarker-dev is a code owner automatically assigned from hashgraph/platform-ci

@leninmehedy leninmehedy Awaiting requested review from leninmehedy

@Ivo-Yankov Ivo-Yankov Awaiting requested review from Ivo-Yankov

@JeffreyDallas JeffreyDallas Awaiting requested review from JeffreyDallas

Assignees

@instamenta instamenta

Labels
PR: Needs Manager Approval A pull request that needs review from a manager. PR: Needs Team Approval A pull request that needs review from a team member.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

move package.json scripts into Taskfile to clean it up and make it less complex
4 participants
@instamenta @jeromy-cannon @JeffreyDallas @andrewb1269hg