refactor: system transactions #17406

mustafauzunn · 2025-01-16T07:34:37Z

Description:

The final PR to support the new format of GossipEvent where transactions will be passed as repeated bytes

Related issue(s):

Fixes #16665

Notes for reviewer:

Checklist

Documented (Code comments, README, etc.)
Tested (unit, integration, etc.)

Signed-off-by: Mustafa Uzun <[email protected]>

…5-system-transaction-refactoring # Conflicts: # platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/eventhandling/DefaultTransactionPrehandler.java # platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/state/SwirldStateManager.java # platform-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/state/TransactionHandler.java

Signed-off-by: Mustafa Uzun <[email protected]>

codecov · 2025-01-16T07:50:16Z

Codecov Report

Attention: Patch coverage is 70.88608% with 23 lines in your changes missing coverage. Please review.

Project coverage is 68.93%. Comparing base (829e18c) to head (446625a).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...om/swirlds/platform/pool/TransactionPoolNexus.java	22.22%	7 Missing ⚠️
.../com/swirlds/platform/builder/PlatformBuilder.java	0.00%	4 Missing ⚠️
.../swirlds/platform/system/events/UnsignedEvent.java	50.00%	3 Missing ⚠️
...rc/main/java/com/hedera/node/app/ServicesMain.java	0.00%	2 Missing ⚠️
.../java/com/swirlds/platform/cli/DiagramCommand.java	0.00%	2 Missing ⚠️
...irlds/platform/system/transaction/Transaction.java	33.33%	1 Missing and 1 partial ⚠️
.../demo/consistency/ConsistencyTestingToolRound.java	0.00%	1 Missing ⚠️
...re/src/main/java/com/swirlds/platform/Browser.java	0.00%	1 Missing ⚠️
...rm/eventhandling/DefaultTransactionPrehandler.java	80.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #17406      +/-   ##
============================================
- Coverage     68.96%   68.93%   -0.03%     
+ Complexity    22763    22758       -5     
============================================
  Files          2619     2619              
  Lines         98283    98260      -23     
  Branches      10185    10183       -2     
============================================
- Hits          67777    67732      -45     
- Misses        26675    26694      +19     
- Partials       3831     3834       +3

Files with missing lines	Coverage Δ
...ows/standalone/impl/StandaloneDispatchFactory.java	`98.41% <100.00%> (-0.05%)`	⬇️
...swirlds/platform/builder/ApplicationCallbacks.java	`100.00% <ø> (ø)`
...m/components/consensus/DefaultConsensusEngine.java	`87.50% <ø> (ø)`
...ction/system/SystemTransactionExtractionUtils.java	`93.75% <ø> (-6.25%)`	⬇️
...java/com/swirlds/platform/event/PlatformEvent.java	`87.61% <100.00%> (-1.77%)`	⬇️
...form/event/creation/tipset/TipsetEventCreator.java	`81.87% <ø> (ø)`
...wirlds/platform/event/hashing/PbjStreamHasher.java	`93.10% <100.00%> (+1.79%)`	⬆️
...ent/resubmitter/DefaultTransactionResubmitter.java	`100.00% <ø> (ø)`
...vent/validation/DefaultInternalEventValidator.java	`81.35% <ø> (-9.04%)`	⬇️
...om/swirlds/platform/metrics/AddedEventMetrics.java	`100.00% <100.00%> (+4.59%)`	⬆️
... and 17 more

... and 10 files with indirect coverage changes

codacy-production · 2025-01-16T07:50:31Z

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
✅ -0.01% (target: -1.00%)	✅ 77.66%

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (`3e8fa1f`)	97675	71128	72.82%
Head commit (`50733eb`)	97689 (+14)	71124 (-4)	72.81% (-0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#17406)	94	73	77.66%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings Change summary preferences

_{Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more}

...form-core/src/main/java/com/swirlds/platform/eventhandling/DefaultTransactionPrehandler.java

...dk/swirlds-platform-core/src/main/java/com/swirlds/platform/pool/DefaultTransactionPool.java

Signed-off-by: Mustafa Uzun <[email protected]>

github-actions · 2025-01-20T09:38:19Z

Node: HAPI Test (Token) Results

28 files 4 errors 24 suites 8s ⏱️
136 tests 0 ✅ 0 💤 136 ❌
226 runs 0 ✅ 0 💤 226 ❌

For more details on these parsing errors and failures, see this check.

Results for commit 1acb251.

♻️ This comment has been updated with latest results.

Signed-off-by: Mustafa Uzun <[email protected]>

…ring' into 16665-system-transaction-refactoring

Signed-off-by: Mustafa Uzun <[email protected]>

github-actions · 2025-01-20T14:55:09Z

Node: HAPI Test (Smart Contract) Results

117 files 2 errors 115 suites 36m 3s ⏱️
169 tests 169 ✅ 0 💤 0 ❌
1 072 runs 1 072 ✅ 0 💤 0 ❌

For more details on these parsing errors, see this check.

Results for commit b64fc96.

♻️ This comment has been updated with latest results.

Signed-off-by: Ivan Kavaldzhiev <[email protected]>

…ring' into 16665-system-transaction-refactoring

lpetrovic05 · 2025-01-21T13:42:21Z

...dk/swirlds-platform-core/src/main/java/com/swirlds/platform/pool/DefaultTransactionPool.java

-        transactionPoolNexus.submitTransaction(
-                new EventTransaction(new OneOf<>(TransactionOneOfType.STATE_SIGNATURE_TRANSACTION, payload)), true);
+        final Bytes payloadBytes = stateLifecycles.encodeSystemTransaction(payload);
+        transactionPoolNexus.submitTransaction(payloadBytes, true, true);


this transformation should be done by a wiring transformer

lpetrovic05 · 2025-01-21T13:44:08Z

...-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/pool/TransactionPoolNexus.java

+    public synchronized boolean submitTransaction(
+            @NonNull final Bytes transaction, final boolean priority, final boolean isSystem) {


priority & isSystem are always equal, can be simplified

lpetrovic05 · 2025-01-21T13:46:06Z

...-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/pool/TransactionPoolNexus.java

-        if (TransactionUtils.getLegacyTransactionSize(transaction) > maximumTransactionSize) {
+        if (TransactionUtils.getLegacyTransactionSize(appTransaction) > maximumTransactionSize) {


@lpetrovic05 create a ticket for this cleanup

lpetrovic05 · 2025-01-21T13:46:16Z

...form-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/state/StateLifecycles.java

+    default Bytes encodeSystemTransaction(@NonNull final StateSignatureTransaction transaction) {
+        throw new IllegalStateException("Invoke the method on the appropriate SwirldMain implementation!");
+    }


should be removed

lpetrovic05 · 2025-01-21T13:53:28Z

...swirlds-platform-core/src/main/java/com/swirlds/platform/system/transaction/Transaction.java

+    Bytes getTransactionBytes();
+


there should be a single method call to get the transaction

lpetrovic05 · 2025-01-21T13:55:05Z

...swirlds-platform-core/src/main/java/com/swirlds/platform/system/transaction/Transaction.java

@@ -39,14 +39,18 @@ public sealed interface Transaction permits ConsensusTransaction {
    @Deprecated
    EventTransaction getTransaction();


seems we dont need this method anymore

lpetrovic05 · 2025-01-21T14:01:31Z

...swirlds-platform-core/src/main/java/com/swirlds/platform/system/transaction/Transaction.java

+    int getBytesSize();
+


there should be a single size method

lpetrovic05 · 2025-01-21T14:03:16Z

...form-sdk/swirlds-platform-core/src/main/java/com/swirlds/platform/util/TransactionUtils.java

    /**
     * Check if a transaction is a system transaction.<br>
     * This is a convenience method that delegates to {@link #isSystemTransaction(OneOf)}.
     *
     * @param transaction the transaction to check
     * @return {@code true} if the transaction is a system transaction, {@code false} otherwise
     */
-    public static boolean isSystemTransaction(@NonNull final EventTransaction transaction) {
-        return isSystemTransaction(transaction.transaction());
+    // TODO: Refactor this method to work properly


lpetrovic05 · 2025-01-21T14:06:59Z

...core/src/testFixtures/java/com/swirlds/platform/test/fixtures/event/TestingEventBuilder.java

+     * <p>
+     * If set to true, transactions will be encoded in the new format of Bytes. If set to false, the deprecated OneOf format will be used.
+     */
+    private boolean useNewTransactionFormat = false;


this should be reverted

Signed-off-by: Mustafa Uzun <[email protected]>

Signed-off-by: Ivan Kavaldzhiev <[email protected]>

…ring' into 16665-system-transaction-refactoring

…ing them to TransactionPool Signed-off-by: Ivan Kavaldzhiev <[email protected]>

…ion-refactoring

Signed-off-by: Ivan Kavaldzhiev <[email protected]>

…ion-refactoring

Signed-off-by: Ivan Kavaldzhiev <[email protected]>

github-actions · 2025-01-22T13:27:12Z

Node: HAPI Test (Misc) Results

74 files 1 errors 73 suites 15m 57s ⏱️
106 tests 85 ✅ 0 💤 21 ❌
463 runs 337 ✅ 0 💤 126 ❌

For more details on these parsing errors and failures, see this check.

Results for commit 5a0b661.

Signed-off-by: Mustafa Uzun <[email protected]>

…ions Signed-off-by: Ivan Kavaldzhiev <[email protected]>

…ring' into 16665-system-transaction-refactoring

github-actions · 2025-01-22T15:08:23Z

Node: HAPI Test (Crypto) Results

30 files 2 errors 28 suites 10s ⏱️
28 tests 0 ✅ 0 💤 28 ❌
344 runs 0 ✅ 0 💤 344 ❌

For more details on these parsing errors and failures, see this check.

Results for commit cb7022e.

Signed-off-by: Ivan Kavaldzhiev <[email protected]>

Signed-off-by: Mustafa Uzun <[email protected]>

…5-system-transaction-refactoring # Conflicts: # hedera-node/hedera-app/src/main/java/com/hedera/node/app/Hedera.java

Signed-off-by: Mustafa Uzun <[email protected]>

mustafauzunn added 4 commits January 14, 2025 13:53

refactor: addapt callback consumer logic

d14f8ea

Signed-off-by: Mustafa Uzun <[email protected]>

refactor: transaction pools

1bb1957

Signed-off-by: Mustafa Uzun <[email protected]>

refactor: after main

39c9d26

Signed-off-by: Mustafa Uzun <[email protected]>

mustafauzunn added the Platform Tickets pertaining to the platform label Jan 16, 2025

mustafauzunn added this to the v0.59 milestone Jan 16, 2025

mustafauzunn self-assigned this Jan 16, 2025

IvanKavaldzhiev reviewed Jan 16, 2025

View reviewed changes

...form-core/src/main/java/com/swirlds/platform/eventhandling/DefaultTransactionPrehandler.java Outdated Show resolved Hide resolved

IvanKavaldzhiev reviewed Jan 16, 2025

View reviewed changes

...dk/swirlds-platform-core/src/main/java/com/swirlds/platform/pool/DefaultTransactionPool.java Outdated Show resolved Hide resolved

mustafauzunn added 10 commits January 16, 2025 14:43

refactor: EventTransaction with Bytes

f253eb3

Signed-off-by: Mustafa Uzun <[email protected]>

refactor: adapt logic with Bytes

1053d02

Signed-off-by: Mustafa Uzun <[email protected]>

refactor: adapt logic for hasher

e907097

Signed-off-by: Mustafa Uzun <[email protected]>

refactor: adapt logic for hasher

ec0d2cd

Signed-off-by: Mustafa Uzun <[email protected]>

refactor: code

40b0940

Signed-off-by: Mustafa Uzun <[email protected]>

refactor: code

ba61264

Signed-off-by: Mustafa Uzun <[email protected]>

style: formatting

e989d5d

Signed-off-by: Mustafa Uzun <[email protected]>

refactor: code

b22154b

Signed-off-by: Mustafa Uzun <[email protected]>

refactor: code

df15758

Signed-off-by: Mustafa Uzun <[email protected]>

refactor: code

31c1566

Signed-off-by: Mustafa Uzun <[email protected]>

mustafauzunn and others added 4 commits January 20, 2025 12:42

refactor: code

48b8acf

Signed-off-by: Mustafa Uzun <[email protected]>

Merge remote-tracking branch 'origin/16665-system-transaction-refacto…

56e00cd

…ring' into 16665-system-transaction-refactoring

refactor: code

a71ba3c

Signed-off-by: Mustafa Uzun <[email protected]>

style: formatting

85c594e

Signed-off-by: Mustafa Uzun <[email protected]>

mustafauzunn and others added 3 commits January 20, 2025 16:57

Merge branch 'main' into 16665-system-transaction-refactoring

6d321a8

fix: unit tests - IssDetectorTests

996073c

Signed-off-by: Ivan Kavaldzhiev <[email protected]>

Merge remote-tracking branch 'origin/16665-system-transaction-refacto…

d9f42bb

…ring' into 16665-system-transaction-refactoring

lpetrovic05 reviewed Jan 21, 2025

View reviewed changes

mustafauzunn and others added 11 commits January 21, 2025 16:35

refactor: code

f359089

Signed-off-by: Mustafa Uzun <[email protected]>

style: formatting

4206348

Signed-off-by: Mustafa Uzun <[email protected]>

nit: revert SystemTransactionExtractionUtils changes

891ca14

Signed-off-by: Ivan Kavaldzhiev <[email protected]>

Merge remote-tracking branch 'origin/16665-system-transaction-refacto…

0dc59f3

…ring' into 16665-system-transaction-refactoring

refactor: use wiring to encode StateSignatureTransactions before pass…

9a0503c

…ing them to TransactionPool Signed-off-by: Ivan Kavaldzhiev <[email protected]>

Merge remote-tracking branch 'origin/main' into 16665-system-transact…

a601c16

…ion-refactoring

nit: fix build

d567b00

Signed-off-by: Ivan Kavaldzhiev <[email protected]>

fix: properly set callback for encoding system transactions

4908e41

Signed-off-by: Ivan Kavaldzhiev <[email protected]>

Merge remote-tracking branch 'origin/main' into 16665-system-transact…

e94a3dc

…ion-refactoring

fix: wiring setup

a27c53c

Signed-off-by: Ivan Kavaldzhiev <[email protected]>

nit: comment unused wire

5a0b661

Signed-off-by: Ivan Kavaldzhiev <[email protected]>

mustafauzunn and others added 4 commits January 22, 2025 15:50

refactor: code

feee18e

Signed-off-by: Mustafa Uzun <[email protected]>

style: formatting

1acb251

Signed-off-by: Mustafa Uzun <[email protected]>

nit: add check for null in encoding method for StateSignatureTransact…

6ef1e48

…ions Signed-off-by: Ivan Kavaldzhiev <[email protected]>

Merge remote-tracking branch 'origin/16665-system-transaction-refacto…

cb7022e

…ring' into 16665-system-transaction-refactoring

IvanKavaldzhiev and others added 4 commits January 22, 2025 17:09

nit: enhance encoding null check

a9d46b3

Signed-off-by: Ivan Kavaldzhiev <[email protected]>

refactor: code

ae0017c

Signed-off-by: Mustafa Uzun <[email protected]>

Merge branch 'main' of github.com:hashgraph/hedera-services into 1666…

a4a6a5e

…5-system-transaction-refactoring # Conflicts: # hedera-node/hedera-app/src/main/java/com/hedera/node/app/Hedera.java

refactor: code

446625a

Signed-off-by: Mustafa Uzun <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: system transactions #17406

refactor: system transactions #17406

mustafauzunn commented Jan 16, 2025

codecov bot commented Jan 16, 2025 •

edited

Loading

codacy-production bot commented Jan 16, 2025 •

edited

Loading

github-actions bot commented Jan 20, 2025 •

edited

Loading

github-actions bot commented Jan 20, 2025 •

edited

Loading

lpetrovic05 Jan 21, 2025

IvanKavaldzhiev Jan 21, 2025

lpetrovic05 Jan 21, 2025

mustafauzunn Jan 22, 2025

lpetrovic05 Jan 21, 2025

lpetrovic05 Jan 21, 2025

IvanKavaldzhiev Jan 21, 2025

lpetrovic05 Jan 21, 2025

lpetrovic05 Jan 21, 2025

lpetrovic05 Jan 21, 2025

mustafauzunn Jan 23, 2025

lpetrovic05 Jan 21, 2025

lpetrovic05 Jan 21, 2025

github-actions bot commented Jan 22, 2025

github-actions bot commented Jan 22, 2025

		public synchronized boolean submitTransaction(
		@NonNull final Bytes transaction, final boolean priority, final boolean isSystem) {

		if (TransactionUtils.getLegacyTransactionSize(transaction) > maximumTransactionSize) {
		if (TransactionUtils.getLegacyTransactionSize(appTransaction) > maximumTransactionSize) {

		@@ -39,14 +39,18 @@ public sealed interface Transaction permits ConsensusTransaction {
		@Deprecated
		EventTransaction getTransaction();

refactor: system transactions #17406

Are you sure you want to change the base?

refactor: system transactions #17406

Conversation

mustafauzunn commented Jan 16, 2025

codecov bot commented Jan 16, 2025 • edited Loading

Codecov Report

codacy-production bot commented Jan 16, 2025 • edited Loading

Coverage summary from Codacy

github-actions bot commented Jan 20, 2025 • edited Loading

Node: HAPI Test (Token) Results

github-actions bot commented Jan 20, 2025 • edited Loading

Node: HAPI Test (Smart Contract) Results

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Jan 22, 2025

Node: HAPI Test (Misc) Results

github-actions bot commented Jan 22, 2025

Node: HAPI Test (Crypto) Results

codecov bot commented Jan 16, 2025 •

edited

Loading

codacy-production bot commented Jan 16, 2025 •

edited

Loading

github-actions bot commented Jan 20, 2025 •

edited

Loading

github-actions bot commented Jan 20, 2025 •

edited

Loading