Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Start the search the first data cluster from start of Segment Element #18

Merged
merged 2 commits into from
Feb 15, 2025

Conversation

gwen-lg
Copy link
Contributor

@gwen-lg gwen-lg commented Feb 14, 2025

Start looking after the Track Element is not valid when located after the Cluster segments.

This should fix issue Can't find the first cluster element #17

PS: I can tried to do a test file, but I'm not sure how to create it with the tool I have.

…ement

Start looking after the `Track Element` is not valid when located after the Cluster segments.

This should fix issue [Can't find the first cluster element hasenbanck#17](hasenbanck#17)
@hasenbanck
Copy link
Owner

In general it looks good to me.

and tracks element at the end of the file.
@gwen-lg
Copy link
Contributor Author

gwen-lg commented Feb 15, 2025

Tntegration test added. Ready for review.

@gwen-lg gwen-lg marked this pull request as ready for review February 15, 2025 12:49
Copy link
Owner

@hasenbanck hasenbanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hasenbanck hasenbanck merged commit 3ded24c into hasenbanck:master Feb 15, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants