Add frame duration management #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hasenbanck
reviewed
Feb 10, 2025
gwen-lg
force-pushed
the
block_duration
branch
from
1a1da53 to
2561959
Compare
hasenbanck
reviewed
Feb 12, 2025
src/error.rs
Outdated
| @@ -117,6 +119,12 @@ impl std::fmt::Display for DemuxError { | |||
| DemuxError::PositiveValueIsNotPositive => { | |||
| write!(f, "a value that should be positive is not positive") | |||
| } | |||
| DemuxError::FrameAlreadyHaveDuration(previous_duration) => { | |||
There was a problem hiding this comment.
DemuxError::FrameAlreadyHasDuration
Subtitle frame generally need a duration. In this case, the Frame is placed in a Block grouped in a GroupBlock with a BlockDuration. Without break the laced frames management. This should fix issue hasenbanck#7 : [Add a duration field to Frame](hasenbanck#7)
gwen-lg
force-pushed
the
block_duration
branch
from
2561959 to
7f12a5a
Compare
hasenbanck
approved these changes
Feb 12, 2025
|
PR now looks fine for merge. |
|
Thank you, do you plan to release a new version of matroska-demuxer after merge ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft:
Subtitle frame generally need a duration.
In this case, the Frame is placed in a Block grouped in a GroupBlock with a BlockDuration. Without break the laced frames management.
This should fix issue #7 : Add a duration field to Frame