-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add management of multiple SeekHead Element #15
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR. I think a test for this change would be helpful to understand it's implementation better.
PR looks fine so far. Can you please add some sort of test for this? |
You think of a mkv file with multiple seekhead ? |
I thought this change was needed to support multiple SeekHead elements. So we should be able to either create the binary stream that implements such multiple heads, or create a test file to do so. Implementing this feature without a test case is not a good idea. |
Some Matroska files have a multiple SeakHead Elements, like a first one who only indicate the position of an SeekHead Element at the end of the file.
the multi_seekhead.mkv file have a first seekhead at start of segment who have the information of a second seekhead segement at end of the file.
I'm able to create a file with two seekhead. |
Yes, the test file and test itself looks fine. Thanks! |
Some Matroska files have a multiple SeakHead Elements, like a first one who only indicate the position of an SeekHead Element at the end of the file.