Skip to content

Make hide_results_on_select option apply for deselecting as well #2924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Make hide_results_on_select option apply for deselecting as well #2924

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ca70c42
Make hide_rsults_on_select option apply for deselecting as well
VanTanev Sep 21, 2017
b998e95
Merge remote-tracking branch 'upstream/master' into hide-results-on-s…
VanTanev Sep 28, 2018
d719289
Do not scroll the selection dropdown up on select when `hide_results_…
VanTanev Sep 28, 2018
7fcd58e
Fix new hide_results_on_select behavior should only be applied on mou…
VanTanev Oct 3, 2018
5e01649
Revert "Fix new hide_results_on_select behavior should only be applie…
VanTanev Oct 4, 2018
b91699d
Revert "Do not scroll the selection dropdown up on select when `hide_…
VanTanev Oct 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion coffee/chosen.jquery.coffee
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,7 +325,7 @@ class Chosen extends AbstractChosen
else
this.show_search_field_default()

this.results_hide() if @is_multiple and this.choices_count() > 0 and this.get_search_field_value().length < 1
this.results_hide() if @is_multiple and this.hide_results_on_select and this.choices_count() > 0 and this.get_search_field_value().length < 1

link.parents('li').first().remove()

Expand Down
2 changes: 1 addition & 1 deletion coffee/chosen.proto.coffee
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,7 @@ class @Chosen extends AbstractChosen
else
this.show_search_field_default()

this.results_hide() if @is_multiple and this.choices_count() > 0 and this.get_search_field_value().length < 1
this.results_hide() if @is_multiple and this.hide_results_on_select and this.choices_count() > 0 and this.get_search_field_value().length < 1

link.up('li').remove()

Expand Down