use a tag instead of abbr tag for search-choice-close #2726
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@mlettini do you have anything to say about this? |
|
stof
reviewed
Oct 17, 2016
coffee/chosen.proto.coffee
Outdated
| @selected_item.down("span").insert { after: "<abbr class=\"search-choice-close\"></abbr>" } unless @selected_item.down("abbr") | ||
| @selected_item.addClassName("chosen-single-with-deselect") | ||
| unless @selected_item.down('.search-choice-close') | ||
| @selected_item.down('span').insert { after: '<a class="search-choice-close"></a>' } |
Contributor
There was a problem hiding this comment.
as there is no href, this won't get a pointer cursor in a cross-browser way (and browsers not showing it are perfectly fine according to the spec)
There was a problem hiding this comment.
Lines 28-30 of sass/chosen.scss force a cursor to all links within .chosen-container, but I agree that no href is less semantic.
Contributor
There was a problem hiding this comment.
proper semantic would probably be a <button type="button"> rather than a <a> btw.
Contributor
Author
|
Updated per @stof's comment about using a button. Removed some duplicate CSS in the process. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #495