Add pagination for list_fme_feature_flags#34
Open
joe-hagerman wants to merge 2 commits intoharness:masterfrom
Open
Add pagination for list_fme_feature_flags#34joe-hagerman wants to merge 2 commits intoharness:masterfrom
joe-hagerman wants to merge 2 commits intoharness:masterfrom
Conversation
|
|
joe-hagerman
force-pushed
the
add-pagination-to-list_fme_feature_flags
branch
from
76090d3 to
c77b0ef
Compare
Contributor
rgrassian-split
left a comment
rgrassian-split
left a comment
There was a problem hiding this comment.
LGTM, minor comments
| mcp.WithNumber("offset", | ||
| mcp.Description("The number of feature flags to skip for pagination (default: 0)"), | ||
| ), | ||
| mcp.WithNumber("count", |
Contributor
There was a problem hiding this comment.
nit: We could use "limit" to keep naming consistent with the API
| // ListFeatureFlags retrieves feature flags for a specific workspace with pagination support. | ||
| // GET https://api.split.io/internal/api/v2/splits/ws/{wsId} | ||
| func (f *FMEService) ListFeatureFlags(ctx context.Context, wsID string) (*dto.FMEFeatureFlagsResponse, error) { | ||
| // offset specifies the number of items to skip; limit controls how many items to return (max 100). |
Contributor
There was a problem hiding this comment.
comment says max 100, but it looks like a max of 50 is actually used
| } | ||
|
|
||
| featureFlags, err := fmeService.ListFeatureFlags(ctx, wsID) | ||
| offset, err := OptionalIntParam(request, "offset") |
Contributor
There was a problem hiding this comment.
nit: check for offset < 0
Contributor
|
Thank you for the suggestions! I can take things from here and get this implemented. |
thisrohangupta
added a commit
to thisrohangupta/harness-mcp-v2
that referenced
this pull request
Mar 6, 2026
Adds fme_feature_flag resource type with list operation using
GET /internal/api/v2/splits/ws/{wsId}. Supports offset and limit
query params (default 20, max 50 per Split.io docs).
Parity with harness/mcp-server#34.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2 tasks
thisrohangupta
added a commit
to thisrohangupta/harness-mcp-v2
that referenced
this pull request
Mar 6, 2026
Adds fme_feature_flag resource type with list operation using
GET /internal/api/v2/splits/ws/{wsId}. Supports offset and limit
query params (default 20, max 50 per Split.io docs).
Parity with harness/mcp-server#34.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
thisrohangupta
added a commit
to thisrohangupta/harness-mcp-v2
that referenced
this pull request
Mar 6, 2026
…-pagination feat: add fme_feature_flag list with pagination (parity with harness/mcp-server#34)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.