Open
Conversation
…o seperate class.
…nges are now taken into account in next onDraw() latest.
… the initial implementation this only collects the untransformed paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for this awsome library! I used it in production code and it works very well. Still there were 2 issues with it:
To solve these issues I needed to restructure the model classes and the way transformations are applied. I measured the drawing time before and after the code changes and it is still pretty much the same.
It should also be possible to resolve issue #3 "Add functionality to dynamically add groups, paths etc. to the Vector" with this implementation, even adding/removing new models is not very comfortable. I did not explicitly tested adding models dynamically.