Always use project deploy start --dry-run for deployment validation…

…, until command `project deploy validate` works with --ignore-warnings & NoTestRun (#796)
hardisgroupcom · Sep 23, 2024 · d6cad4f · d6cad4f
1 parent f191d7b
commit d6cad4f
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,10 @@
 
 Note: Can be used with `sfdx plugins:install sfdx-hardis@beta` and docker image `hardisgroupcom/sfdx-hardis@beta`
 
+## [5.0.1] 2024-09-23
+
+- Always use `project deploy start --dry-run` for deployment validation, until command `project deploy validate` works with --ignore-warnings & NoTestRun
+
 ## [5.0.0] 2024-09-23
 
 ### Refactoring explanations

diff --git a/src/common/utils/deployUtils.ts b/src/common/utils/deployUtils.ts
@@ -279,10 +279,12 @@ export async function smartDeploy(
       const branchConfig = await getConfig('branch');
       const deployCommand =
         `sf project deploy` +
-        (check && testlevel !== 'NoTestRun' ? ' validate' : ' start') +
-        (check && testlevel === 'NoTestRun' ? ' --dry-run' : '') + // validate with NoTestRun does not work, so use --dry-run
+        // (check && testlevel !== 'NoTestRun' ? ' validate' : ' start') + // Not until validate command is correct and accepts ignore-warnings
+        ' start' +
+        // (check && testlevel === 'NoTestRun' ? ' --dry-run' : '') + // validate with NoTestRun does not work, so use --dry-run
+        (check ? ' --dry-run' : '') +
         ` --manifest "${deployment.packageXmlFile}"` +
-        (check === false ? ' --ignore-warnings' : '') + // So it does not fail in for objectTranslations stuff for example
+        ' --ignore-warnings' + // So it does not fail in for objectTranslations stuff for example
         ` --test-level ${testlevel}` +
         (options.testClasses && testlevel !== 'NoTestRun' ? ` --tests ${options.testClasses}` : '') +
         (options.preDestructiveChanges ? ` --pre-destructive-changes ${options.preDestructiveChanges}` : '') +